fix: manual virtual index adjustments (CP: 14.8) #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
commented
May 13, 2022
Comment on lines
+285
to
+301
| const isScrollingDown = delta >= 0; | ||
| const reusables = this._getReusables(!isScrollingDown); | ||
|
|
||
| if (reusables.indexes.length) { | ||
| // After running super._scrollHandler, fix internal properties to workaround an iron-list issue. | ||
| // See https://github.com/vaadin/web-components/issues/1691 | ||
| this._physicalTop = reusables.physicalTop; | ||
|
|
||
| if (isScrollingDown) { | ||
| this._virtualStart -= reusables.indexes.length; | ||
| this._physicalStart -= reusables.indexes.length; | ||
| } else { | ||
| this._virtualStart += reusables.indexes.length; | ||
| this._physicalStart += reusables.indexes.length; | ||
| } | ||
| this._update(reusables.indexes, !isScrollingDown); | ||
| } |
There was a problem hiding this comment.
This is basically a copy of the logic in iron-list's _scrollHandler. In certain situation (with large enough item count and scrollbar scrolling) the logic may not get executed when it should.
web-padawan
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vaadin/web-components#1691
Backport vaadin/web-components#3843 and vaadin/web-components#3849 for V14.8