fix: manual virtual index adjustments #3843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
force-pushed
the
fix-virtualizer-rows-visibility
branch
from
90de528
to
4e36c5e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
commented
May 13, 2022
Comment on lines
+307
to
+312
| if (this._physicalCount !== 0) { | ||
| // After running super._scrollHandler, fix _virtualStart to workaround an iron-list issue. | ||
| // See https://github.com/vaadin/web-components/issues/1691 | ||
| const reusables = this._getReusables(true); | ||
| this._virtualStart += reusables.indexes.length; | ||
| } |
There was a problem hiding this comment.
Just calling this._render() here would be enough to fix the issue, but to avoid unnecessary overhead, let's just run the minimal necessary subset of the function.
web-padawan
approved these changes
May 13, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
May 13, 2022
tomivirkki
added a commit
that referenced
this pull request
May 13, 2022
Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com> Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1691