Fix review comments

- Incorrect indentation - Remove notify not needed for title/description
vaadin · Dec 14, 2018 · 2af45c3 · 2af45c3
1 parent 7fc4fd4
commit 2af45c3
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 39 deletions.
diff --git a/src/vaadin-login-overlay-element.html b/src/vaadin-login-overlay-element.html
@@ -9,45 +9,45 @@
 <link rel="import" href="../../vaadin-overlay/src/vaadin-overlay.html">
 
 <dom-module id="vaadin-login-overlay-element-template">
-    <template>
+  <template>
     <style>
-        [part="overlay"] {
-          outline: none;
-        }
+      [part="overlay"] {
+        outline: none;
+      }
 
-        [part="card"] {
-          max-width: 100%;
-          box-sizing: border-box;
-          overflow: hidden;
-          display: flex;
-          flex-direction: column;
-        }
+      [part="card"] {
+        max-width: 100%;
+        box-sizing: border-box;
+        overflow: hidden;
+        display: flex;
+        flex-direction: column;
+      }
 
-        [part="brand"] {
-          box-sizing: border-box;
-          overflow: hidden;
-          flex-grow: 1;
-          flex-shrink: 0;
-          display: flex;
-          flex-direction: column;
-          justify-content: flex-end;
-        }
+      [part="brand"] {
+        box-sizing: border-box;
+        overflow: hidden;
+        flex-grow: 1;
+        flex-shrink: 0;
+        display: flex;
+        flex-direction: column;
+        justify-content: flex-end;
+      }
 
-        [part="brand"] h1 {
-          color: inherit;
-          margin: 0;
-        }
-      </style>
-      <section part="card">
-        <div part="brand">
-          <h1>[[title]]</h1>
-          <p>[[description]]</p>
-        </div>
-        <div part="form">
-          <slot></slot>
-        </div>
-      </section>
-    </template>
+      [part="brand"] h1 {
+        color: inherit;
+        margin: 0;
+      }
+    </style>
+    <section part="card">
+      <div part="brand">
+        <h1>[[title]]</h1>
+        <p>[[description]]</p>
+      </div>
+      <div part="form">
+        <slot></slot>
+      </div>
+    </section>
+  </template>
     <script>
       (function() {
         let memoizedTemplate;

diff --git a/src/vaadin-login-overlay.html b/src/vaadin-login-overlay.html
@@ -63,16 +63,14 @@
             opened: {
               type: Boolean,
               value: false,
-              observer: '_onOpenedChange',
-              notify: true
+              observer: '_onOpenedChange'
             },
             /**
              * Defines the application title
              */
             title: {
               type: String,
-              value: 'App name',
-              notify: true
+              value: 'App name'
             }
           };
         }