fix: close a notification on detach (#3834)

vaadin · May 12, 2022 · c79a2ae · c79a2ae
1 parent 921f61e
commit c79a2ae
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 0 deletions.
diff --git a/dev/notification.html b/dev/notification.html
@@ -0,0 +1,22 @@
+<!DOCTYPE html>
+<html lang="en">
+  <head>
+    <meta charset="UTF-8" />
+    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
+    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+    <title>Notification</title>
+    <script type="module" src="./common.js"></script>
+  </head>
+
+  <body>
+    <vaadin-notification position="middle" duration="0" theme="success"></vaadin-notification>
+
+    <script type="module">
+      import '@vaadin/notification';
+
+      const notification = document.querySelector('vaadin-notification');
+      notification.renderer = root => root.textContent = 'Financial report generated';
+      notification.open();
+    </script>
+  </body>
+</html>
diff --git a/packages/notification/src/vaadin-notification.js b/packages/notification/src/vaadin-notification.js
@@ -328,6 +328,12 @@ class Notification extends ThemePropertyMixin(ElementMixin(PolymerElement)) {
     processTemplates(this);
   }
 
+  /** @protected */
+  disconnectedCallback() {
+    super.disconnectedCallback();
+    this.opened = false;
+  }
+
   /**
    * Requests an update for the content of the notification.
    * While performing the update, it invokes the renderer passed in the `renderer` property.

diff --git a/packages/notification/test/notification.test.js b/packages/notification/test/notification.test.js
@@ -34,6 +34,12 @@ describe('vaadin-notification', () => {
     expect(notification._card.getAttribute('id')).to.be.null;
   });
 
+  it('should close on detach', () => {
+    expect(notification.opened).to.be.true;
+    notification.remove();
+    expect(notification.opened).to.be.false;
+  });
+
   describe('vaadin-notification-container', () => {
     it('should be in the body when notification opens', () => {
       expect(document.body.querySelectorAll('vaadin-notification-container').length).to.be.equal(1);