Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crud relies on grid's size #6302

Closed
tomivirkki opened this issue Aug 4, 2023 · 1 comment
Closed

Crud relies on grid's size #6302

tomivirkki opened this issue Aug 4, 2023 · 1 comment
Assignees

Comments

@tomivirkki
Copy link
Member

Description

<vaadin-crud> component relies on the internal <vaadin-grid> to update its size property when new items are added/removed. This doesn't happen, however, which results in Crud not dispatching size-changed event on item removals/additions.

Expected outcome

The size-changed should dispatch from crud. It's debatable, however, whether the grid should automatically update its own size property. It merely reflects the count of the root-level items.

Minimal reproducible example

https://vaadin.com/docs/latest/components/crud#toolbar (TypeScript)

Steps to reproduce

Add or remove items. The "Total" value in the toolbar never updates

Environment

Vaadin version(s): 24

Browsers

Issue is not browser related

@tomivirkki
Copy link
Member Author

Turns out this has already been fixed by #6982. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants