refactor: remove iron-resizable-behavior from combo-box #3195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
force-pushed
the
combo-box-remove-iron-resizable-behavior
branch
from
2a9d793
to
6e2800e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Dec 15, 2021
|
Hi @tomivirkki , this commit cannot be picked to 22.0 by this bot, can you take a look and pick it manually? |
36 tasks
|
This ticket/PR has been released with platform 23.0.0.alpha1 and is also targeting the upcoming stable 23.0.0 version. |
web-padawan
pushed a commit
that referenced
this pull request
Feb 16, 2022
web-padawan
pushed a commit
that referenced
this pull request
Feb 16, 2022
web-padawan
added a commit
that referenced
this pull request
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IronResizableBehaviorhasn't been necessary for<vaadin-combo-box>since replacing the internal overlay positioning logic withvaadin-overlay-position-mixinPart of #331