Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Germany special holidays #1595

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Refactor Germany special holidays (2017 Reformation Day and 75th anniversary of the liberation from Nazism and the end of the Second World War in Europe).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@coveralls
Copy link

coveralls commented Dec 17, 2023

Pull Request Test Coverage Report for Build 7277549951

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7277480097: 0.0%
Covered Lines: 10247
Relevant Lines: 10247

💛 - Coveralls

# Conflicts:
#	holidays/countries/germany.py
Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇩🇪 LGTM

@arkid15r arkid15r added this pull request to the merge queue Dec 22, 2023
Merged via the queue into vacanza:beta with commit 80e40e7 Dec 22, 2023
26 checks passed
@KJhellico KJhellico deleted the ref-germany branch December 22, 2023 17:52
@KJhellico KJhellico mentioned this pull request Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants