Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Uzbekistan holidays, add l10n support #1622

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Update Uzbekistan holidays, add l10n support #1622

merged 4 commits into from
Jan 5, 2024

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Update Uzbekistan holidays, add l10n support (en_US, uk, uz).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@coveralls
Copy link

coveralls commented Jan 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7425079764

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7420685584: 0.0%
Covered Lines: 10247
Relevant Lines: 10247
💛 - Coveralls

arkid15r
arkid15r reviewed Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

holidays/countries/uzbekistan.py Show resolved Hide resolved
holidays/countries/uzbekistan.py Outdated Show resolved Hide resolved
@KJhellico
Fix estimated label
5e5e6fb
@KJhellico
Merge branch 'beta' into upd-uzbekistan
4889ff9 
# Conflicts:
#	snapshots/countries/UZ_COMMON.json
#	tests/countries/test_uzbekistan.py
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

12 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

arkid15r
arkid15r approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

holidays/countries/uzbekistan.py Show resolved Hide resolved
@arkid15r arkid15r added this pull request to the merge queue Jan 5, 2024
Merged via the queue into vacanza:beta with commit 58cd972 Jan 5, 2024
26 checks passed
@KJhellico KJhellico deleted the upd-uzbekistan branch January 5, 2024 18:49
@arkid15r arkid15r mentioned this pull request Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KJhellico @coveralls @arkid15r