Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Georgian government holiday for May 17, 2024 #1802

Merged
merged 4 commits into from
May 24, 2024

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented May 23, 2024

Proposed change

Add Georgian government holiday for May 17, 2024 "Day of Family Sanctity and Respect for Parents" (ოჯახის სიწმინდისა და მშობლების პატივისცემის დღე) as decreed by Resolution No. 167. Ukrainian translation is cross-referenced with [1] .

Resolves #1795.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@coveralls
Copy link

coveralls commented May 23, 2024

Pull Request Test Coverage Report for Build 9227416733

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9217292461: 0.0%
Covered Lines: 11283
Relevant Lines: 11283

💛 - Coveralls

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

I have a l10 suggestion though. Also I'd like to know @KJhellico's preferred translation option.

Thank you @PPsyrius!

holidays/locale/uk/LC_MESSAGES/GE.po Outdated Show resolved Hide resolved
snapshots/countries/GE_COMMON.json Outdated Show resolved Hide resolved
holidays/countries/georgia.py Outdated Show resolved Hide resolved
holidays/locale/en_US/LC_MESSAGES/GE.po Outdated Show resolved Hide resolved
holidays/locale/ka/LC_MESSAGES/GE.po Outdated Show resolved Hide resolved
holidays/locale/uk/LC_MESSAGES/GE.po Outdated Show resolved Hide resolved
holidays/locale/en_US/LC_MESSAGES/GE.po Outdated Show resolved Hide resolved
tests/countries/test_georgia.py Outdated Show resolved Hide resolved
PPsyrius and others added 2 commits May 24, 2024 09:57
@PPsyrius PPsyrius requested a review from arkid15r May 24, 2024 03:21
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@arkid15r arkid15r enabled auto-merge May 24, 2024 17:38
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇬🇪

@arkid15r arkid15r added this pull request to the merge queue May 24, 2024
Merged via the queue into vacanza:dev with commit a487bd3 May 24, 2024
29 checks passed
@PPsyrius PPsyrius deleted the sakartvelo_may_17_holiday branch May 25, 2024 03:44
@KJhellico KJhellico mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

May 17th, 2024 is a holiday in Georgia
4 participants