Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruff configuration #1819

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

arkid15r
Copy link
Collaborator

@arkid15r arkid15r commented Jun 7, 2024

Proposed change

Update ruff configuration:

  • enforce E5 category, delete E501 suppressions
  • enforce N category, add N802 suppressions
  • enforce W category

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

  - enforce E5 category, delete E501 suppressions
  - enforce N category, add N802 suppressions
  - enforce W category
@arkid15r arkid15r requested a review from KJhellico as a code owner June 7, 2024 18:57
Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
25 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

coveralls commented Jun 7, 2024

Pull Request Test Coverage Report for Build 9421834272

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9393429174: 0.0%
Covered Lines: 11338
Relevant Lines: 11338

💛 - Coveralls

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Jun 10, 2024
Merged via the queue into vacanza:dev with commit edbd32d Jun 10, 2024
29 checks passed
@arkid15r arkid15r deleted the update-ruff-config branch June 10, 2024 15:50
@arkid15r arkid15r mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants