Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing/moving createCloneToken functionality #31

Closed
0x-r4bbit opened this issue Sep 22, 2023 · 2 comments · Fixed by #34
Closed

Consider removing/moving createCloneToken functionality #31

0x-r4bbit opened this issue Sep 22, 2023 · 2 comments · Fixed by #34
Assignees
@3esmit
Labels
enhancement New feature or request

Comments

@0x-r4bbit
Copy link
Collaborator

This might be an extension to #7 but the idea would be to enable the creation of MiniMeToken that don't need/have createCloneToken functionality
@3esmit 3esmit added the enhancement New feature or request label Sep 22, 2023
@3esmit
Copy link

3esmit commented Sep 23, 2023

Ultimately, the function in the MiniMeToken contract would be removed, but the functionality would still be possible by creating a new minimetoken from a creating a new token and setting the parent token and snapshot block, or using a factory.

@0x-r4bbit
Copy link
Collaborator Author

That sounds about right!

@3esmit 3esmit self-assigned this Sep 25, 2023
@3esmit 3esmit mentioned this issue Sep 25, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@3esmit 3esmit

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove createCloneToken function vacp2p/minime
2 participants
@3esmit @0x-r4bbit