Waku 0: Handshake

[decanus]

Problem

There is currently no part of the specification that clearly outlines the handshake and how it occurs.

Acceptance criteria

• The handshake is documented within the waku spec.

[adambabik]

For the reference, here is the implementation: https://github.com/status-im/whisper/blob/master/whisperv6/peer.go#L93

[kdeme]

Is this enough covered now here: https://github.com/vacp2p/specs/blob/master/waku.md#packet-usage ? Or do we need a better description?

Any additional field such as the confirmationsEnabled that can be seen in the status geth version should probably be added and explained by @adambabik or somebody else of status-core.

[adambabik]

I don't see any explanation what should be sent in a handshake in https://github.com/vacp2p/specs/blob/master/waku.md#packet-usage. There is this:

Status message should be sent after the RLPx handshake and prior to any other messages.

but status code is a handshake from what I understand from the implementation.

We need to describe that a handshake is a status packet followed by protocol version, PoW, bloom, mode (currently true/false but I think we need to send here either a light node or waku mode or whatever else; it might be a bit map).

Regarding the message confirmation, here is an issue: #30. Let's figure out that one first and if needed we can extend the handshake definition.

[decanus]

yeah @kdeme I'd like to see a more explicit explanation. As mentioned by @adambabik

[oskarth]

@kdeme whats the state of this?

[kdeme]

I've added this under the explanation of the Status message, see: https://github.com/vacp2p/specs/blob/master/waku.md#packet-usage

I'll close, please reopen if it is not sufficient.