feat(rln-v2): update serde for rln-v2 #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
added
the
track:rln
Benchmark for 3b2dcb5Click to view benchmark
|
Benchmark for 3b2dcb5Click to view benchmark
|
|
Note: the tests will fail till we get the new artifacts from the rln-v2 ceremony |
Benchmark for c891214Click to view benchmark
|
Benchmark for c891214Click to view benchmark
|
rymnc
force-pushed
the
update-serde-rln-v2
branch
from
758d853
to
2132779
Compare
Benchmark for f5f9910Click to view benchmark
|
Benchmark for 7694126Click to view benchmark
|
Benchmark for 7694126Click to view benchmark
|
Benchmark for f5f9910Click to view benchmark
|
richard-ramos
approved these changes
Aug 11, 2023
While it's not the case, maybe we should keep the failing code at a temporary branch? |
Yes, merging into |
rymnc
added a commit
that referenced
this pull request
Aug 17, 2023
* feat(rln-v2): update serde for rln-v2 * fix: public tests that needed to append the new fields
rymnc
added a commit
that referenced
this pull request
Oct 3, 2023
* feat(rln-v2): update serde for rln-v2 (#202) * feat(rln-v2): update serde for rln-v2 * fix: public tests that needed to append the new fields * s/id_commitments/rate_commitments (#205) * feat: rename public, protocol and update tests to use rate_commitments * fix: into() * `message_id` range check (#210) * feature: range check added * fmt * feature: message_id_range_check * fix: corresponding change of types * comments: function level * fmt * fix(rln): tests (#212) * most changes * fix * fix protocol tests * fmt * ffi tests fix * feat(rln-v2): new artifacts, removed older ones (#211) * feat(rln-v2): new artifacts, removed older ones * wip: working branch * fix: remove more refs to epoch + rln_identifier * Updated serde in RLN proof verification * Updated artifacts * chore: update * chore: update * hardcoded test works * fix: proof generation and verification * fix: rln-wasm tests * fix: ffi tests * fix: rln-wasm test * fix: recover_id_secret * Fix message (#217) --------- Co-authored-by: rymnc <43716372+rymnc@users.noreply.github.com> * chore: Release --------- Co-authored-by: tyshko-rostyslav <122977916+tyshko-rostyslav@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/Rate-Limiting-Nullifier/circom-rln/blob/17f0fed7d8d19e8b127fd0b3e5295a4831193a0d/circuits/rln.circom#L8-L16 we see that there are 2 additional
private inputs,
user_message_limitandmessage_id, this PR adds it to the serde api's.