Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix message #217

Merged
merged 26 commits into from
Oct 3, 2023
Merged

Fix message #217

merged 26 commits into from
Oct 3, 2023

Conversation

tyshko-rostyslav
Copy link
Contributor

Fixing test_recover_id_secret test though fixing serialization

@tyshko-rostyslav tyshko-rostyslav changed the base branch from rln-v2 to new-artifacts September 18, 2023 07:30
@github-actions
Copy link

Benchmark for 5c64600

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1542.0±55.79ns 1475.3±87.64ns -4.33%
FullMerkleTree::get 4.4±0.13ns 4.4±0.12ns 0.00%
FullMerkleTree::override_range 4.0±0.26µs 3.8±0.23µs -5.00%
FullMerkleTree::set 1545.7±75.10ns 1455.5±49.42ns -5.84%
OptimalMerkleTree::compute_root 1783.7±72.32ns 1642.0±74.16ns -7.94%
OptimalMerkleTree::delete 1712.6±58.98ns 1636.9±72.88ns -4.42%
OptimalMerkleTree::get 33.0±0.82ns 30.6±1.83ns -7.27%
OptimalMerkleTree::override_range 8.9±0.49µs 8.2±0.44µs -7.87%
OptimalMerkleTree::set 1726.4±50.86ns 1645.0±81.20ns -4.72%

@github-actions
Copy link

Benchmark for 5c64600

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.4±0.02ns 2.4±0.00ns 0.00%
Pmtree::get 553.5±1.81ns 555.9±1.65ns +0.43%
Pmtree::override_range 220.2±12.18µs 225.8±16.57µs +2.54%
Pmtree::set 83.4±2.57µs 82.7±0.55µs -0.84%
Pmtree:delete 83.5±0.43µs 83.7±0.89µs +0.24%

@github-actions
Copy link

Benchmark for 7c05e53

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1201.7±1.83ns 1224.2±1.91ns +1.87%
FullMerkleTree::get 3.6±0.02ns 3.6±0.01ns 0.00%
FullMerkleTree::override_range 3.1±0.00µs 3.0±0.00µs -3.23%
FullMerkleTree::set 1205.6±3.10ns 1202.4±3.59ns -0.27%
OptimalMerkleTree::compute_root 1394.0±3.57ns 1432.4±3.99ns +2.75%
OptimalMerkleTree::delete 1381.2±1.37ns 1390.6±1.89ns +0.68%
OptimalMerkleTree::get 29.6±0.11ns 28.9±0.12ns -2.36%
OptimalMerkleTree::override_range 7.1±0.02µs 7.0±0.04µs -1.41%
OptimalMerkleTree::set 1387.0±1.50ns 1398.7±9.93ns +0.84%

@github-actions
Copy link

Benchmark for f169a44

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1583.0±50.75ns 1579.1±50.94ns -0.25%
FullMerkleTree::get 4.4±0.20ns 4.6±0.28ns +4.55%
FullMerkleTree::override_range 3.8±0.21µs 3.9±0.21µs +2.63%
FullMerkleTree::set 1559.9±58.04ns 1570.4±90.62ns +0.67%
OptimalMerkleTree::compute_root 1830.2±77.09ns 1783.1±91.49ns -2.57%
OptimalMerkleTree::delete 1868.3±89.35ns 1757.0±96.33ns -5.96%
OptimalMerkleTree::get 33.7±1.45ns 33.0±2.35ns -2.08%
OptimalMerkleTree::override_range 9.1±0.63µs 9.2±1.13µs +1.10%
OptimalMerkleTree::set 1919.2±229.13ns 1732.4±118.30ns -9.73%

@github-actions
Copy link

Benchmark for f169a44

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.0±0.00ns 2.0±0.00ns 0.00%
Pmtree::get 499.2±16.83ns 466.9±0.91ns -6.47%
Pmtree::override_range 184.9±6.77µs 180.1±4.93µs -2.60%
Pmtree::set 69.7±0.79µs 69.3±0.28µs -0.57%
Pmtree:delete 69.7±0.07µs 69.5±0.05µs -0.29%

@github-actions
Copy link

Benchmark for 7c05e53

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.4±0.05ns 2.3±0.05ns -4.17%
Pmtree::get 546.2±11.26ns 542.4±7.56ns -0.70%
Pmtree::override_range 216.9±15.68µs 221.7±22.25µs +2.21%
Pmtree::set 81.0±1.96µs 82.2±1.26µs +1.48%
Pmtree:delete 83.0±2.95µs 82.7±0.60µs -0.36%

@github-actions
Copy link

Benchmark for f3f3933

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1486.9±1.33ns 1483.9±7.28ns -0.20%
FullMerkleTree::get 4.8±0.05ns 4.8±0.04ns 0.00%
FullMerkleTree::override_range 3.7±0.00µs 3.7±0.02µs 0.00%
FullMerkleTree::set 1486.7±0.88ns 1484.6±10.95ns -0.14%
OptimalMerkleTree::compute_root 1676.4±3.03ns 1668.4±4.94ns -0.48%
OptimalMerkleTree::delete 1665.0±2.58ns 1660.4±1.64ns -0.28%
OptimalMerkleTree::get 32.1±0.05ns 30.9±0.21ns -3.74%
OptimalMerkleTree::override_range 8.5±0.01µs 8.5±0.21µs 0.00%
OptimalMerkleTree::set 1665.1±21.06ns 1661.8±1.74ns -0.20%

@github-actions
Copy link

Benchmark for f3f3933

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.4±0.10ns 2.3±0.20ns -4.17%
Pmtree::get 620.6±28.66ns 581.5±34.90ns -6.30%
Pmtree::override_range 244.6±32.87µs 268.2±51.72µs +9.65%
Pmtree::set 86.9±11.74µs 82.5±6.59µs -5.06%
Pmtree:delete 83.7±5.08µs 82.3±6.91µs -1.67%

@tyshko-rostyslav tyshko-rostyslav marked this pull request as ready for review September 18, 2023 09:31
rymnc
rymnc reviewed Sep 21, 2023
View reviewed changes
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, curious about usage of message_id

rln/src/protocol.rs Outdated Show resolved Hide resolved
@github-actions
Copy link

Benchmark for c91444c

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1437.5±28.35ns 1447.0±22.68ns +0.66%
FullMerkleTree::get 4.5±0.11ns 4.6±0.10ns +2.22%
FullMerkleTree::override_range 3.6±0.07µs 3.5±0.08µs -2.78%
FullMerkleTree::set 1413.4±29.72ns 1391.1±53.13ns -1.58%
OptimalMerkleTree::compute_root 1578.0±27.44ns 1594.9±26.68ns +1.07%
OptimalMerkleTree::delete 1578.6±17.24ns 1566.9±40.75ns -0.74%
OptimalMerkleTree::get 29.7±0.43ns 29.8±0.40ns +0.34%
OptimalMerkleTree::override_range 7.9±0.37µs 8.1±0.16µs +2.53%
OptimalMerkleTree::set 1575.3±21.93ns 1582.0±21.81ns +0.43%

@github-actions
Copy link

Benchmark for c91444c

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.0±0.00ns 2.0±0.00ns 0.00%
Pmtree::get 464.4±0.54ns 464.7±0.44ns +0.06%
Pmtree::override_range 175.0±7.99µs 178.4±5.56µs +1.94%
Pmtree::set 67.6±0.05µs 67.8±0.73µs +0.30%
Pmtree:delete 67.6±0.05µs 68.1±0.08µs +0.74%

rymnc
rymnc reviewed Sep 29, 2023
View reviewed changes
rln/src/protocol.rs Outdated Show resolved Hide resolved
@rymnc rymnc mentioned this pull request Sep 30, 2023
Merged
@github-actions
Copy link

Benchmark for 85a62d4

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1251.4±1.89ns 1243.0±14.71ns -0.67%
FullMerkleTree::get 4.0±0.02ns 4.0±0.05ns 0.00%
FullMerkleTree::override_range 3.2±0.00µs 3.1±0.00µs -3.13%
FullMerkleTree::set 1258.7±1.89ns 1313.6±335.46ns +4.36%
OptimalMerkleTree::compute_root 1396.4±1.86ns 1393.0±1.99ns -0.24%
OptimalMerkleTree::delete 1387.2±1.12ns 1391.0±1.18ns +0.27%
OptimalMerkleTree::get 26.0±0.05ns 26.6±0.02ns +2.31%
OptimalMerkleTree::override_range 7.1±0.02µs 7.1±0.01µs 0.00%
OptimalMerkleTree::set 1389.0±3.21ns 1394.9±17.99ns +0.42%

@github-actions
Copy link

Benchmark for 85a62d4

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.4±0.02ns 2.4±0.02ns 0.00%
Pmtree::get 558.2±0.37ns 546.9±6.83ns -2.02%
Pmtree::override_range 211.8±12.28µs 211.8±12.01µs 0.00%
Pmtree::set 81.2±0.97µs 81.1±0.10µs -0.12%
Pmtree:delete 80.9±0.33µs 82.0±0.58µs +1.36%

@github-actions
Copy link

Benchmark for c916b83

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1255.2±0.69ns 1241.1±0.70ns -1.12%
FullMerkleTree::get 4.0±0.03ns 4.0±0.06ns 0.00%
FullMerkleTree::override_range 3.2±0.00µs 3.1±0.06µs -3.13%
FullMerkleTree::set 1255.6±1.11ns 1240.5±0.64ns -1.20%
OptimalMerkleTree::compute_root 1413.0±1.10ns 1389.7±1.49ns -1.65%
OptimalMerkleTree::delete 1408.2±0.94ns 1388.7±5.88ns -1.38%
OptimalMerkleTree::get 26.3±0.02ns 26.0±0.02ns -1.14%
OptimalMerkleTree::override_range 7.2±0.01µs 7.1±0.01µs -1.39%
OptimalMerkleTree::set 1408.2±1.03ns 1389.2±14.21ns -1.35%

@github-actions
Copy link

Benchmark for c916b83

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.0±0.03ns 2.1±0.04ns +5.00%
Pmtree::get 454.2±0.21ns 454.8±0.16ns +0.13%
Pmtree::override_range 177.3±11.72µs 180.9±21.82µs +2.03%
Pmtree::set 67.2±0.28µs 67.5±0.07µs +0.45%
Pmtree:delete 67.8±0.08µs 67.5±0.06µs -0.44%

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Benchmark for f4f6f63

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1502.1±14.15ns 1510.6±10.14ns +0.57%
FullMerkleTree::get 4.8±0.05ns 4.8±0.05ns 0.00%
FullMerkleTree::override_range 3.8±0.02µs 3.8±0.01µs 0.00%
FullMerkleTree::set 1512.0±1.10ns 1517.9±1.52ns +0.39%
OptimalMerkleTree::compute_root 1671.4±1.51ns 1691.1±156.84ns +1.18%
OptimalMerkleTree::delete 1668.6±9.81ns 1665.7±1.64ns -0.17%
OptimalMerkleTree::get 31.2±0.02ns 31.7±0.44ns +1.60%
OptimalMerkleTree::override_range 8.8±0.01µs 8.6±0.01µs -2.27%
OptimalMerkleTree::set 1672.6±23.49ns 1667.2±15.71ns -0.32%

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Benchmark for f4f6f63

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.5±0.15ns 2.5±0.14ns 0.00%
Pmtree::get 604.5±34.02ns 620.5±45.67ns +2.65%
Pmtree::override_range 271.4±20.40µs 281.1±26.15µs +3.57%
Pmtree::set 92.4±5.95µs 92.2±6.75µs -0.22%
Pmtree:delete 94.0±7.64µs 91.2±4.41µs -2.98%

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Benchmark for ed3e485

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1240.6±0.84ns 1240.9±1.03ns +0.02%
FullMerkleTree::get 4.0±0.01ns 4.0±0.02ns 0.00%
FullMerkleTree::override_range 3.1±0.00µs 3.1±0.01µs 0.00%
FullMerkleTree::set 1241.3±1.34ns 1241.7±2.65ns +0.03%
OptimalMerkleTree::compute_root 1409.6±102.76ns 1392.8±1.40ns -1.19%
OptimalMerkleTree::delete 1395.9±1.99ns 1387.8±0.99ns -0.58%
OptimalMerkleTree::get 26.0±0.03ns 26.8±0.03ns +3.08%
OptimalMerkleTree::override_range 7.1±0.01µs 7.1±0.01µs 0.00%
OptimalMerkleTree::set 1394.2±0.94ns 1387.5±3.19ns -0.48%

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Benchmark for 2bc0cd8

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1242.5±0.70ns 1241.0±0.63ns -0.12%
FullMerkleTree::get 4.7±0.02ns 4.0±0.02ns -14.89%
FullMerkleTree::override_range 3.1±0.01µs 3.1±0.00µs 0.00%
FullMerkleTree::set 1243.2±0.84ns 1241.5±0.63ns -0.14%
OptimalMerkleTree::compute_root 1395.8±5.95ns 1397.5±1.17ns +0.12%
OptimalMerkleTree::delete 1389.2±4.01ns 1402.1±80.63ns +0.93%
OptimalMerkleTree::get 27.0±0.03ns 26.8±0.04ns -0.74%
OptimalMerkleTree::override_range 7.1±0.05µs 7.1±0.02µs 0.00%
OptimalMerkleTree::set 1390.3±17.47ns 1391.5±8.41ns +0.09%

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Benchmark for ed3e485

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.1±0.05ns 2.1±0.04ns 0.00%
Pmtree::get 453.2±1.66ns 457.1±0.27ns +0.86%
Pmtree::override_range 176.2±7.17µs 183.8±19.81µs +4.31%
Pmtree::set 67.2±0.36µs 67.3±0.22µs +0.15%
Pmtree:delete 67.3±1.53µs 67.3±0.40µs 0.00%

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Benchmark for 2bc0cd8

Click to view benchmark
Test Base PR %
Pmtree::compute_root 1.6±0.00ns 1.6±0.00ns 0.00%
Pmtree::get 461.5±3.97ns 469.4±0.52ns +1.71%
Pmtree::override_range 174.3±5.75µs 175.8±7.32µs +0.86%
Pmtree::set 69.6±0.04µs 69.7±0.47µs +0.14%
Pmtree:delete 69.9±0.07µs 69.6±0.03µs -0.43%

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Benchmark for aba53f8

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1489.1±1.64ns 1490.5±1.04ns +0.09%
FullMerkleTree::get 4.8±0.05ns 4.8±0.03ns 0.00%
FullMerkleTree::override_range 3.8±0.00µs 3.8±0.00µs 0.00%
FullMerkleTree::set 1489.2±0.72ns 1489.2±1.06ns 0.00%
OptimalMerkleTree::compute_root 1675.1±1.42ns 1672.2±7.88ns -0.17%
OptimalMerkleTree::delete 1670.8±2.07ns 1667.3±1.91ns -0.21%
OptimalMerkleTree::get 33.9±0.05ns 32.1±0.02ns -5.31%
OptimalMerkleTree::override_range 8.5±0.01µs 8.6±0.06µs +1.18%
OptimalMerkleTree::set 1671.3±19.84ns 1667.6±7.89ns -0.22%

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Benchmark for aba53f8

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.4±0.03ns 2.4±0.05ns 0.00%
Pmtree::get 541.9±8.80ns 540.3±5.93ns -0.30%
Pmtree::override_range 213.3±6.84µs 214.6±12.37µs +0.61%
Pmtree::set 79.5±1.28µs 80.5±1.16µs +1.26%
Pmtree:delete 79.2±1.54µs 79.6±0.99µs +0.51%

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Benchmark for 3cb4cff

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1480.7±47.96ns 1550.6±33.22ns +4.72%
FullMerkleTree::get 4.8±0.12ns 4.8±0.16ns 0.00%
FullMerkleTree::override_range 3.7±0.11µs 3.9±0.19µs +5.41%
FullMerkleTree::set 1500.3±41.27ns 1549.4±76.79ns +3.27%
OptimalMerkleTree::compute_root 1747.9±52.34ns 1752.7±88.59ns +0.27%
OptimalMerkleTree::delete 1742.1±39.33ns 1755.4±51.66ns +0.76%
OptimalMerkleTree::get 33.5±2.32ns 32.9±0.57ns -1.79%
OptimalMerkleTree::override_range 8.8±0.23µs 9.0±0.25µs +2.27%
OptimalMerkleTree::set 1732.9±33.64ns 1766.5±83.49ns +1.94%

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Benchmark for 3cb4cff

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.4±0.01ns 2.4±0.02ns 0.00%
Pmtree::get 560.4±3.17ns 551.5±0.58ns -1.59%
Pmtree::override_range 264.2±39.14µs 255.5±34.61µs -3.29%
Pmtree::set 82.2±4.15µs 80.9±0.57µs -1.58%
Pmtree:delete 80.9±0.13µs 81.0±0.79µs +0.12%

rymnc
rymnc approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit

rln/src/public.rs Outdated Show resolved Hide resolved
@tyshko-rostyslav tyshko-rostyslav merged commit f64ae3a into rln-v2 Oct 3, 2023
16 checks passed
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Benchmark for 4dbed28

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1212.4±1.17ns 1206.9±1.56ns -0.45%
FullMerkleTree::get 3.6±0.01ns 3.6±0.02ns 0.00%
FullMerkleTree::override_range 3.1±0.00µs 3.1±0.00µs 0.00%
FullMerkleTree::set 1215.0±1.81ns 1205.6±1.23ns -0.77%
OptimalMerkleTree::compute_root 1444.0±6.15ns 1461.3±1.23ns +1.20%
OptimalMerkleTree::delete 1453.2±2.23ns 1453.4±1.98ns +0.01%
OptimalMerkleTree::get 28.4±0.06ns 28.5±0.07ns +0.35%
OptimalMerkleTree::override_range 7.5±0.00µs 7.4±0.04µs -1.33%
OptimalMerkleTree::set 1418.5±15.08ns 1443.8±10.22ns +1.78%

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Benchmark for 4dbed28

Click to view benchmark
Test Base PR %
Pmtree::compute_root 1.6±0.00ns 1.6±0.02ns 0.00%
Pmtree::get 459.8±0.43ns 466.2±0.94ns +1.39%
Pmtree::override_range 173.9±4.72µs 173.3±5.85µs -0.35%
Pmtree::set 70.4±0.06µs 69.6±0.04µs -1.14%
Pmtree:delete 69.8±0.06µs 69.6±0.04µs -0.29%

rymnc added a commit that referenced this pull request Oct 3, 2023
@rymnc @tyshko-rostyslav
feat: rln-v2 (#204)
8614b2a 
* feat(rln-v2): update serde for rln-v2 (#202)

* feat(rln-v2): update serde for rln-v2

* fix: public tests that needed to append the new fields

* s/id_commitments/rate_commitments (#205)

* feat: rename public, protocol and update tests to use rate_commitments

* fix: into()

* `message_id` range check (#210)

* feature: range check added

* fmt

* feature: message_id_range_check

* fix: corresponding change of types

* comments: function level

* fmt

* fix(rln): tests (#212)

* most changes

* fix

* fix protocol tests

* fmt

* ffi tests fix

* feat(rln-v2): new artifacts, removed older ones (#211)

* feat(rln-v2): new artifacts, removed older ones

* wip: working branch

* fix: remove more refs to epoch + rln_identifier

* Updated serde in RLN proof verification

* Updated artifacts

* chore: update

* chore: update

* hardcoded test works

* fix: proof generation and verification

* fix: rln-wasm tests

* fix: ffi tests

* fix: rln-wasm test

* fix: recover_id_secret

* Fix message (#217)



---------

Co-authored-by: rymnc <43716372+rymnc@users.noreply.github.com>

* chore: Release

---------

Co-authored-by: tyshko-rostyslav <122977916+tyshko-rostyslav@users.noreply.github.com>
@rymnc rymnc deleted the fix-message_id branch October 18, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rymnc rymnc rymnc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tyshko-rostyslav @rymnc