Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rln-v2): new artifacts, removed older ones #211

Merged
merged 9 commits into from
Sep 30, 2023
Merged

feat(rln-v2): new artifacts, removed older ones #211

merged 9 commits into from
Sep 30, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Sep 4, 2023 •
edited

Fetched from https://ceremony.pse.dev/projects/RLN%20Trusted%20Setup%20Ceremony

we also removed the rln circuits submodule

@rymnc rymnc changed the base branch from master to rln-v2 September 4, 2023 09:22
@rymnc rymnc self-assigned this Sep 4, 2023
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Benchmark for 59d081e

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1552.9±72.84ns 1542.9±80.86ns -0.64%
FullMerkleTree::get 0.1±0.00ns 0.0±0.00ns -100.00%
FullMerkleTree::override_range 3.9±0.22µs 3.9±0.19µs 0.00%
FullMerkleTree::set 1612.4±168.71ns 1618.0±79.59ns +0.35%
OptimalMerkleTree::compute_root 1796.1±118.30ns 1821.7±103.92ns +1.43%
OptimalMerkleTree::delete 1716.1±129.37ns 1728.1±80.69ns +0.70%
OptimalMerkleTree::get 38.1±1.98ns 40.5±1.42ns +6.30%
OptimalMerkleTree::override_range 8.8±0.66µs 9.1±0.89µs +3.41%
OptimalMerkleTree::set 1713.1±65.20ns 1776.4±104.35ns +3.70%

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Benchmark for 59d081e

Click to view benchmark
Test Base PR %
Pmtree::compute_root 1.6±0.00ns 1.6±0.00ns 0.00%
Pmtree::get 493.4±0.42ns 468.8±0.33ns -4.99%
Pmtree::override_range 169.1±9.47µs 172.3±13.91µs +1.89%
Pmtree::set 66.5±0.11µs 69.9±0.05µs +5.11%
Pmtree:delete 66.5±0.05µs 68.8±0.04µs +3.46%

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Benchmark for b76ecbd

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1211.7±2.02ns 1220.5±2.13ns +0.73%
FullMerkleTree::get 0.1±0.00ns 0.1±0.00ns 0.00%
FullMerkleTree::override_range 3.0±0.00µs 3.0±0.00µs 0.00%
FullMerkleTree::set 1215.2±7.42ns 1211.9±1.97ns -0.27%
OptimalMerkleTree::compute_root 1389.6±1.70ns 1391.2±1.71ns +0.12%
OptimalMerkleTree::delete 1382.5±1.46ns 1380.7±1.36ns -0.13%
OptimalMerkleTree::get 30.6±0.05ns 30.8±0.12ns +0.65%
OptimalMerkleTree::override_range 7.0±0.01µs 7.1±0.01µs +1.43%
OptimalMerkleTree::set 1380.7±14.84ns 1384.6±2.02ns +0.28%

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Benchmark for b76ecbd

Click to view benchmark
Test Base PR %
Pmtree::compute_root 1.6±0.00ns 1.6±0.00ns 0.00%
Pmtree::get 478.4±0.45ns 480.4±0.42ns +0.42%
Pmtree::override_range 165.4±5.20µs 168.5±12.36µs +1.87%
Pmtree::set 69.5±0.52µs 67.3±0.06µs -3.17%
Pmtree:delete 67.5±0.09µs 67.7±0.04µs +0.30%

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Benchmark for f4e55dd

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1586.7±0.94ns 1553.4±1.30ns -2.10%
FullMerkleTree::get 0.1±0.00ns 0.1±0.00ns 0.00%
FullMerkleTree::override_range 3.9±0.00µs 3.9±0.00µs 0.00%
FullMerkleTree::set 1561.4±46.53ns 1562.2±1.32ns +0.05%
OptimalMerkleTree::compute_root 1738.3±5.40ns 1734.2±2.71ns -0.24%
OptimalMerkleTree::delete 1729.2±5.75ns 1731.3±1.33ns +0.12%
OptimalMerkleTree::get 39.8±0.03ns 36.4±0.04ns -8.54%
OptimalMerkleTree::override_range 9.0±0.01µs 8.8±0.06µs -2.22%
OptimalMerkleTree::set 1736.0±2.36ns 1733.6±18.35ns -0.14%

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Benchmark for f4e55dd

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.0±0.02ns 2.1±0.11ns +5.00%
Pmtree::get 560.3±0.99ns 564.3±1.47ns +0.71%
Pmtree::override_range 219.7±13.03µs 215.4±18.02µs -1.96%
Pmtree::set 79.2±0.57µs 80.2±0.11µs +1.26%
Pmtree:delete 79.3±0.13µs 79.2±0.08µs -0.13%

@github-actions
Copy link

Benchmark for 3deccf5

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1109.0±2.36ns 1093.5±1.72ns -1.40%
FullMerkleTree::get 3.5±0.01ns 3.5±0.05ns 0.00%
FullMerkleTree::override_range 2.7±0.01µs 2.8±0.01µs +3.70%
FullMerkleTree::set 1106.5±0.76ns 1092.8±2.74ns -1.24%
OptimalMerkleTree::compute_root 1243.6±4.03ns 1220.4±6.29ns -1.87%
OptimalMerkleTree::delete 1254.8±1.23ns 1223.3±7.57ns -2.51%
OptimalMerkleTree::get 23.4±0.03ns 22.6±0.09ns -3.42%
OptimalMerkleTree::override_range 6.2±0.00µs 6.2±0.01µs 0.00%
OptimalMerkleTree::set 1243.2±13.32ns 1221.4±2.05ns -1.75%

@github-actions
Copy link

Benchmark for 3deccf5

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.4±0.01ns 2.4±0.00ns 0.00%
Pmtree::get 554.4±5.75ns 560.3±0.54ns +1.06%
Pmtree::override_range 217.4±7.36µs 229.7±18.55µs +5.66%
Pmtree::set 85.4±2.73µs 83.2±0.29µs -2.58%
Pmtree:delete 83.2±0.10µs 83.8±0.58µs +0.72%

@github-actions
Copy link

Benchmark for 6a7818f

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1204.4±1.67ns 1202.6±1.99ns -0.15%
FullMerkleTree::get 3.6±0.00ns 3.6±0.00ns 0.00%
FullMerkleTree::override_range 3.0±0.01µs 3.0±0.02µs 0.00%
FullMerkleTree::set 1200.9±2.46ns 1204.0±2.09ns +0.26%
OptimalMerkleTree::compute_root 1382.6±5.13ns 1379.7±1.36ns -0.21%
OptimalMerkleTree::delete 1369.9±1.22ns 1369.8±1.82ns -0.01%
OptimalMerkleTree::get 28.8±0.11ns 28.7±0.12ns -0.35%
OptimalMerkleTree::override_range 7.0±0.03µs 7.0±0.05µs 0.00%
OptimalMerkleTree::set 1376.6±1.40ns 1372.9±12.13ns -0.27%

@github-actions
Copy link

Benchmark for 6a7818f

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.0±0.00ns 2.0±0.00ns 0.00%
Pmtree::get 472.5±0.23ns 463.9±0.17ns -1.82%
Pmtree::override_range 175.8±6.68µs 177.8±10.33µs +1.14%
Pmtree::set 69.6±0.05µs 69.0±0.06µs -0.86%
Pmtree:delete 69.3±0.04µs 69.7±0.05µs +0.58%

@github-actions
Copy link

Benchmark for f01d9a3

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1204.9±1.58ns 1205.9±2.63ns +0.08%
FullMerkleTree::get 3.6±0.07ns 3.6±0.00ns 0.00%
FullMerkleTree::override_range 3.0±0.00µs 3.0±0.00µs 0.00%
FullMerkleTree::set 1201.1±1.76ns 1201.1±1.98ns 0.00%
OptimalMerkleTree::compute_root 1388.9±1.88ns 1388.5±1.48ns -0.03%
OptimalMerkleTree::delete 1383.1±1.14ns 1388.9±6.11ns +0.42%
OptimalMerkleTree::get 28.9±0.08ns 29.0±0.11ns +0.35%
OptimalMerkleTree::override_range 7.1±0.02µs 7.1±0.01µs 0.00%
OptimalMerkleTree::set 1387.1±13.38ns 1389.4±12.70ns +0.17%

@github-actions
Copy link

Benchmark for f01d9a3

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.4±0.06ns 2.5±0.25ns +4.17%
Pmtree::get 537.6±6.91ns 553.1±10.16ns +2.88%
Pmtree::override_range 224.5±13.62µs 224.0±19.15µs -0.22%
Pmtree::set 83.9±3.54µs 81.7±1.01µs -2.62%
Pmtree:delete 81.5±1.01µs 82.2±0.88µs +0.86%

@github-actions
Copy link

Benchmark for 7b78f15

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1208.7±2.11ns 1201.3±1.91ns -0.61%
FullMerkleTree::get 3.6±0.00ns 3.6±0.00ns 0.00%
FullMerkleTree::override_range 3.0±0.01µs 3.0±0.00µs 0.00%
FullMerkleTree::set 1211.8±2.12ns 1204.5±3.40ns -0.60%
OptimalMerkleTree::compute_root 1409.9±1.57ns 1392.0±2.38ns -1.27%
OptimalMerkleTree::delete 1419.1±1.94ns 1382.5±1.39ns -2.58%
OptimalMerkleTree::get 28.8±0.13ns 28.7±0.17ns -0.35%
OptimalMerkleTree::override_range 7.1±0.01µs 7.1±0.05µs 0.00%
OptimalMerkleTree::set 1383.8±14.49ns 1383.3±4.59ns -0.04%

@github-actions
Copy link

Benchmark for 7b78f15

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.0±0.00ns 2.0±0.01ns 0.00%
Pmtree::get 469.0±0.22ns 463.6±0.25ns -1.15%
Pmtree::override_range 176.6±13.09µs 178.5±13.79µs +1.08%
Pmtree::set 69.3±0.45µs 73.5±17.62µs +6.06%
Pmtree:delete 69.3±0.32µs 69.3±0.27µs 0.00%

@github-actions
Copy link

Benchmark for c362834

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1499.0±88.20ns 1491.2±5.19ns -0.52%
FullMerkleTree::get 4.8±0.05ns 4.8±0.00ns 0.00%
FullMerkleTree::override_range 3.8±0.00µs 3.8±0.01µs 0.00%
FullMerkleTree::set 1488.8±8.31ns 1489.6±5.26ns +0.05%
OptimalMerkleTree::compute_root 1676.8±3.27ns 1670.5±1.08ns -0.38%
OptimalMerkleTree::delete 1761.8±115.23ns 1658.1±5.46ns -5.89%
OptimalMerkleTree::get 31.4±0.02ns 32.0±0.28ns +1.91%
OptimalMerkleTree::override_range 8.5±0.01µs 8.5±0.01µs 0.00%
OptimalMerkleTree::set 1731.9±99.10ns 1705.6±90.57ns -1.52%

@github-actions
Copy link

Benchmark for c362834

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.0±0.00ns 2.0±0.00ns 0.00%
Pmtree::get 478.1±1.28ns 464.4±0.22ns -2.87%
Pmtree::override_range 176.9±3.70µs 180.0±6.22µs +1.75%
Pmtree::set 69.2±0.03µs 70.0±0.25µs +1.16%
Pmtree:delete 68.8±0.04µs 69.3±0.14µs +0.73%

@github-actions
Copy link

Benchmark for 35710f2

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1246.6±3.90ns 1249.1±0.53ns +0.20%
FullMerkleTree::get 4.0±0.02ns 4.0±0.04ns 0.00%
FullMerkleTree::override_range 3.1±0.00µs 3.2±0.04µs +3.23%
FullMerkleTree::set 1255.4±6.00ns 1259.2±0.48ns +0.30%
OptimalMerkleTree::compute_root 1437.4±49.84ns 1386.5±1.59ns -3.54%
OptimalMerkleTree::delete 1423.2±1.28ns 1387.8±1.23ns -2.49%
OptimalMerkleTree::get 26.0±0.02ns 25.5±0.01ns -1.92%
OptimalMerkleTree::override_range 7.1±0.01µs 7.3±0.01µs +2.82%
OptimalMerkleTree::set 1406.0±14.96ns 1388.5±13.15ns -1.24%

@github-actions
Copy link

Benchmark for 35710f2

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.0±0.03ns 2.0±0.03ns 0.00%
Pmtree::get 453.6±0.44ns 462.1±0.30ns +1.87%
Pmtree::override_range 177.9±5.79µs 182.2±12.14µs +2.42%
Pmtree::set 67.0±0.76µs 68.0±7.01µs +1.49%
Pmtree:delete 66.9±0.28µs 68.1±0.24µs +1.79%

@rymnc rymnc marked this pull request as ready for review September 30, 2023 07:04
@rymnc
Copy link
Contributor Author

rymnc commented Sep 30, 2023

The only test failing is compute_id_secret, which is being taken care of in #217

@rymnc rymnc merged commit 30b9c5a into rln-v2 Sep 30, 2023
10 of 16 checks passed
@rymnc rymnc deleted the new-artifacts branch September 30, 2023 07:04
rymnc added a commit that referenced this pull request Oct 3, 2023
@rymnc @tyshko-rostyslav
feat: rln-v2 (#204)
8614b2a 
* feat(rln-v2): update serde for rln-v2 (#202)

* feat(rln-v2): update serde for rln-v2

* fix: public tests that needed to append the new fields

* s/id_commitments/rate_commitments (#205)

* feat: rename public, protocol and update tests to use rate_commitments

* fix: into()

* `message_id` range check (#210)

* feature: range check added

* fmt

* feature: message_id_range_check

* fix: corresponding change of types

* comments: function level

* fmt

* fix(rln): tests (#212)

* most changes

* fix

* fix protocol tests

* fmt

* ffi tests fix

* feat(rln-v2): new artifacts, removed older ones (#211)

* feat(rln-v2): new artifacts, removed older ones

* wip: working branch

* fix: remove more refs to epoch + rln_identifier

* Updated serde in RLN proof verification

* Updated artifacts

* chore: update

* chore: update

* hardcoded test works

* fix: proof generation and verification

* fix: rln-wasm tests

* fix: ffi tests

* fix: rln-wasm test

* fix: recover_id_secret

* Fix message (#217)



---------

Co-authored-by: rymnc <43716372+rymnc@users.noreply.github.com>

* chore: Release

---------

Co-authored-by: tyshko-rostyslav <122977916+tyshko-rostyslav@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rymnc rymnc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rymnc