Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shell commands copyable in the readme #481

Merged
merged 1 commit into from
Oct 17, 2021

Conversation

LitoMore
Copy link
Contributor

@LitoMore LitoMore commented Oct 7, 2021

Changes

  • Remove $ prefix from shell commands
  • Specify the language for code block

@vadimdemedes
Copy link
Owner

Remove $ prefix from shell commands

I'd prefer to leave it there, I like how it makes it clear that it's a shell command.

Specify the language for code block

Doesn't seem like sh language adds any highlighting?

@LitoMore
Copy link
Contributor Author

LitoMore commented Oct 8, 2021

I'd prefer to leave it there, I like how it makes it clear that it's a shell command.

Since GitHub launched the copy-text feature for code blocks, no $ will more convenient. Users can copy-paste and run.

Doesn't seem like sh language adds any highlighting?

Yes, it's not highlighted. But just for now. Even if it doesn't have any highlighting, we can still specify a language for it. Just in case.

@vadimdemedes
Copy link
Owner

vadimdemedes commented Oct 8, 2021

Ok sounds good. Thanks!

@sindresorhus sindresorhus changed the title Update readme Make shell commands copyable in the readme Oct 12, 2021
@vadimdemedes vadimdemedes merged commit 8b8e6e5 into vadimdemedes:master Oct 17, 2021
@LitoMore LitoMore deleted the update-readme branch October 17, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants