Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reordering during click #33

Closed
Emkacf opened this issue Nov 14, 2017 · 7 comments
Closed

Reordering during click #33

Emkacf opened this issue Nov 14, 2017 · 7 comments
Labels

Comments

@Emkacf
Copy link

Emkacf commented Nov 14, 2017

Hi,

I've implemented the ngx-order-pipe in angular 5 app where I am sorting the table on which rows are clickable to show more data and pipe is reordering the rows on click. May it be angular 5 compatibility issue/bug or I am doing something wrong?

`<ng-container *ngFor="let vdb of vdbs | orderBy: order">'

And my structure looks like that (clicking on row toogle the hidden table with multiple rows):

table
  row
    hidden table
  row
    hidden table

My sortable field is in main table rows

order: string = 'content.properties.DOMAIN.__text';

@tabirkeland
Copy link

tabirkeland commented Nov 27, 2017

Same issue. I believe it is due to the pipe being impure, changed in this commit 90216f4. I created my own pipe that extends the OrderPipe like so:

import { Pipe } from '@angular/core';

import { OrderPipe } from 'ngx-order-pipe'

@Pipe({name: 'orderColumn'})
export class OrderColumnPipe extends OrderPipe
{

}

Working fine.

@MarkusPint
Copy link

Same issue

@VadimDez
Copy link
Owner

What version of ngx-order-pipe are you using?

@nosTa1337
Copy link

I had the same problem with the latest version and solved it with @tabirkeland solution. thanks.

@grobii
Copy link

grobii commented Mar 6, 2018

For me, it's working with version 2.0.1

@bluecaret
Copy link

Thank you @tabirkeland your solution worked for me as well!

@stale
Copy link

stale bot commented Jul 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 31, 2020
@stale stale bot closed this as completed Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants