Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a foreign language-only filter for Subscene #433

Merged
merged 8 commits into from
Jun 2, 2023
Merged

Implement a foreign language-only filter for Subscene #433

merged 8 commits into from
Jun 2, 2023

Conversation

vagabondHustler
Copy link
Owner

  • Added a new configuration option for filtering subtitles by foreign languages only.
  • Implemented the UI component for toggling the foreign language filter.
  • Updated the Subscene provider to send the foreign language filter value in the request header.
  • Created a new SubsceneCookie data class to store the configuration values related to Subscene.
  • Updated the AppConfig data class to include the foreign_only attribute.
  • Added the foreign_only attribute to the application configuration JSON file.
  • Modified the JSON I/O functions to handle the new attribute.

@vagabondHustler
Feat add subscene language id as int
04af59c
@vagabondHustler
Feat add foreign language only filter to Subscene
13ed62d 
- Added a new configuration option for filtering subtitles by foreign languages only.
- Implemented the UI component for toggling the foreign language filter.
- Updated the Subscene provider to send the foreign language filter value in the request header.
- Created a new SubsceneCookie data class to store the configuration values related to Subscene.
- Updated the AppConfig data class to include the foreign_only attribute.
- Added the foreign_only attribute to the application configuration JSON file.
- Modified the JSON I/O functions to handle the new attribute.
@vagabondHustler vagabondHustler linked an issue Jun 1, 2023 that may be closed by this pull request
[REQUEST] - Foreign Only Option #422
Closed
@vagabondHustler vagabondHustler added the feat A new feature label Jun 1, 2023
@vagabondHustler vagabondHustler changed the title Implement foreign language only filder for Subscene Implement foreign language only filter for Subscene Jun 1, 2023
@vagabondHustler vagabondHustler changed the title Implement foreign language only filter for Subscene Implement a foreign language-only filter for Subscene Jun 1, 2023
@vagabondHustler
Feat add foreign language-only filter for Subscene
67449ad 
- Added a new configuration option for filtering subtitles by foreign languages only.
- Implemented the UI component for toggling the foreign language filter.
- Updated the Subscene provider to send the foreign language filter value in the request header.
- Created a new SubsceneCookie data class to store the configuration values related to Subscene.
- Updated the AppConfig data class to include the foreign_only attribute.
- Added the foreign_only attribute to the application configuration JSON file.
- Modified the JSON I/O functions to handle the new attribute.
@vagabondHustler
Merge branch 'feature/foreign_only_subscene/230601165808' of https://…
31566c4 
…github.com/vagabondHustler/subsearch into feature/foreign_only_subscene/230601165808
@vagabondHustler vagabondHustler marked this pull request as ready for review June 1, 2023 21:15
vagabondHustler and others added 2 commits June 2, 2023 00:14
@vagabondHustler
Merge branch 'main' into feature/foreign_only_subscene/230601165808
5db534f
@vagabondHustler
Feat add option to toggle foreign language only
956f356 
- Added a new toggle button in the search tab GUI called "Foreign language only" to allow the user to toggle whether to search for foreign language subtitles only.
- Modified the AppSteps class in core.py to retrieve the value of the "foreign_only" configuration key using io_json.get_json_key and store it in the foreign_only attribute.
- Modified the SkipStep class in core.py to check the foreign_only attribute when skipping the opensubtitles and yifysubtitles steps.
- Updated the ToggleableFrameButton class in tkinter_utils.py to accept an optional tip_text parameter and display a tooltip with the provided text when available.
- Updated the SubsceneScraper class in subscene.py to skip items with the child text content "upload" to avoid selecting irrelevant links.
- Updated the Subscene class in subscene.py to create a custom header using the CustomSubsceneHeader class from the generic module, and added the necessary import statement.
- Updated the Subscene class to pass the custom header to the find_subtitles method when searching for subtitles.
- Renamed the function io_json.create_application_config to io_json.create_application_config_json to match the file format.
- Updated the function call in the AppSteps class accordingly.
@vagabondHustler vagabondHustler self-assigned this Jun 2, 2023
@vagabondHustler
Fix update subscene_id for Khmer language
7437ea9 
- Updated the `subscene_id`  for the Khmer language from null to 79.
@vagabondHustler
Refactor update tip_text output
f9c0a46 
- Updated the text displayed when hovering over the foreign language only button with the mouse.
This was referenced Jun 2, 2023
Closed
Closed
@vagabondHustler vagabondHustler merged commit 00987c7 into main Jun 2, 2023
3 checks passed
@vagabondHustler vagabondHustler deleted the feature/foreign_only_subscene/230601165808 branch June 2, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vagabondHustler vagabondHustler

Labels
feat A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REQUEST] - Foreign Only Option
1 participant
@vagabondHustler