Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] - Foreign Only Option #422

Closed
ondrovic opened this issue May 13, 2023 · 5 comments · Fixed by #433
Closed

[REQUEST] - Foreign Only Option #422

ondrovic opened this issue May 13, 2023 · 5 comments · Fixed by #433
Labels
feature request Requested feature

Comments

@ondrovic
Copy link

Is your feature request related to a problem? Please describe.
Ability to download only the subtitles that are foreign only
Describe the solution you'd like
Adding a search option to allow for only downloading Foreign only (I know subscene.com has this option as a valid filter)

Describe alternatives you've considered
Downloading the foreign only manually one at a time

Additional context
Add any other context or screenshots about the feature request here.

@ondrovic ondrovic added the feature request Requested feature label May 13, 2023
@vagabondHustler
Copy link
Owner

Sounds like a good implementation. Do you know any movies or TV shows on subscene that have 'Foreign language only ' subtitles? I'm not too familiar with that type of subtitles, so if you could suggest a few titles, it would be really helpful.

@vagabondHustler
Copy link
Owner

vagabondHustler commented May 17, 2023

It turns out that retrieving information about 'foreign parts only' from Subscene isn't as straightforward as I initially thought. While details like language and hearing-impaired options are available, the availability of subtitles exclusively for foreign parts is not.

However, I did notice that some subtitle uploaders mention the 'foreign parts only' information in the 'Comment' section. The problem is that different uploaders may use different phrases like 'foreign parts only' or 'non-English parts,' making it unreliable.

Modifying the cookie could work, found these values in the cookie.

DarkTheme=True; SortSubtitlesByDate=false; LanguageFilter=13; HearingImpaired=2; ForeignOnly=False; __cf_bm=<hash>;

But to be honest, I'm not familiar with that and would need to look up how to do that.

I have not checked the other sites yet, but will.

@ondrovic
Copy link
Author

@vagabondHustler no worries if it turns out to ne more trouble than it's worth not a big deal

@vagabondHustler
Copy link
Owner

@ondrovic, I don't mind if it's much work. If this cookie thing isn't working for me, I think I might just implement some kind of feature where the user can define keywords like 'Foreign only,' 'Foreign parts only,' 'non-English.' Then, when scraping Subscene for subtitles, my app can check if those keywords are present in the subtitle comments. Additionally, I could include another feature where it ignores subtitle comments containing words like 'whatever,' providing the opposite effect.

Just gotta find some time to do all that :)

@vagabondHustler vagabondHustler added the wip work in progress label May 25, 2023
@vagabondHustler vagabondHustler linked a pull request Jun 1, 2023 that will close this issue
@vagabondHustler vagabondHustler removed the wip work in progress label Jun 2, 2023
@vagabondHustler
Copy link
Owner

This issue will be closed when PR #433 is merged. Further progress will be tracked in in Issue #434. It seems like implementing the same method for opensubtitles.org should be relatively straightforward. Unsure if it's possible to implement it for yifysubtitles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requested feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants