Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a foreign language-only filter for Subscene #433

Merged
merged 8 commits into from
Jun 2, 2023

Commits on Jun 1, 2023

  1. Configuration menu
    Copy the full SHA
    04af59c View commit details
    Browse the repository at this point in the history
  2. Feat add foreign language only filter to Subscene

    - Added a new configuration option for filtering subtitles by foreign languages only.
    - Implemented the UI component for toggling the foreign language filter.
    - Updated the Subscene provider to send the foreign language filter value in the request header.
    - Created a new SubsceneCookie data class to store the configuration values related to Subscene.
    - Updated the AppConfig data class to include the foreign_only attribute.
    - Added the foreign_only attribute to the application configuration JSON file.
    - Modified the JSON I/O functions to handle the new attribute.
    vagabondHustler committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    13ed62d View commit details
    Browse the repository at this point in the history
  3. Feat add foreign language-only filter for Subscene

    - Added a new configuration option for filtering subtitles by foreign languages only.
    - Implemented the UI component for toggling the foreign language filter.
    - Updated the Subscene provider to send the foreign language filter value in the request header.
    - Created a new SubsceneCookie data class to store the configuration values related to Subscene.
    - Updated the AppConfig data class to include the foreign_only attribute.
    - Added the foreign_only attribute to the application configuration JSON file.
    - Modified the JSON I/O functions to handle the new attribute.
    vagabondHustler committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    67449ad View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    31566c4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5db534f View commit details
    Browse the repository at this point in the history
  6. Feat add option to toggle foreign language only

    - Added a new toggle button in the search tab GUI called "Foreign language only" to allow the user to toggle whether to search for foreign language subtitles only.
    - Modified the AppSteps class in core.py to retrieve the value of the "foreign_only" configuration key using io_json.get_json_key and store it in the foreign_only attribute.
    - Modified the SkipStep class in core.py to check the foreign_only attribute when skipping the opensubtitles and yifysubtitles steps.
    - Updated the ToggleableFrameButton class in tkinter_utils.py to accept an optional tip_text parameter and display a tooltip with the provided text when available.
    - Updated the SubsceneScraper class in subscene.py to skip items with the child text content "upload" to avoid selecting irrelevant links.
    - Updated the Subscene class in subscene.py to create a custom header using the CustomSubsceneHeader class from the generic module, and added the necessary import statement.
    - Updated the Subscene class to pass the custom header to the find_subtitles method when searching for subtitles.
    - Renamed the function io_json.create_application_config to io_json.create_application_config_json to match the file format.
    - Updated the function call in the AppSteps class accordingly.
    vagabondHustler committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    956f356 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Fix update subscene_id for Khmer language

    - Updated the `subscene_id`  for the Khmer language from null to 79.
    vagabondHustler committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    7437ea9 View commit details
    Browse the repository at this point in the history
  2. Refactor update tip_text output

    - Updated the text displayed when hovering over the foreign language only button with the mouse.
    vagabondHustler committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    f9c0a46 View commit details
    Browse the repository at this point in the history