Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest eslint-config-valantic version #319

Closed
benjamin-joham opened this issue May 25, 2023 · 0 comments
Closed

Update to latest eslint-config-valantic version #319

benjamin-joham opened this issue May 25, 2023 · 0 comments
Assignees

Comments

@benjamin-joham
Copy link
Contributor

The eslint config packages should be updated and the changes with the incoming rules should be applied to the codebase.
This can partly be done by running npm run fix:eslint. In the case of @typescript-eslint/naming-convention this can be done with regex.

Regex

find: ( |:|\[|<)([IET](?!ODO))([A-Z]){1}(\w+)(| | \{|\{|\(|\[|>| \||,|;|\))
replace: $1$3$4$5

Explanation

$1. ( |:|\[|<) all possibles characters before the interface declaration/usage
$2. ([IET](?!ODO)) everything starting with one of E/I/T and not followed by ODO to ignore TODO
$3. ([A-Z]){1} the next uppercase letter
$4. (\w+) next word
$5. (| | \{|\{|\(|\[|>| \||,|;|\)) all possible characters after the interface declaration/usage

Packages to be updated

  • eslint-config-valantic@16.0.1
  • eslint-plugin-vue@9.11.0

Rules that will be inherited

With the update of the packages the following rules can be removed from .eslintrc.json

  • space-before-function-paren
  • max-lines
  • no-undefined
@benjamin-joham benjamin-joham changed the title update to latest eslint-config-valantic version Update to latest eslint-config-valantic version May 25, 2023
@benjamin-joham benjamin-joham self-assigned this May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant