Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userId / password = connectionKey/Secret #2

Open
crouchingtiger opened this issue Aug 28, 2017 · 1 comment
Open

userId / password = connectionKey/Secret #2

crouchingtiger opened this issue Aug 28, 2017 · 1 comment

Comments

@crouchingtiger
Copy link

crouchingtiger commented Aug 28, 2017

private $userId;
/**
* @var string
*/
private $password;

ck and cs in the CONNACK packet denote connection key and connection secret. Might be a bit confusing to use userId and password here in the traditional MQTT sense.

@valga
Copy link
Owner

valga commented Aug 28, 2017

A proper solution would include:

  1. Creating new FbnsAuth class for handling JSON data. It will have FBNS-aware names for properties.
  2. Adding new method buildFromFbnsAuth to DeviceAuth class that will convert FBNS-aware properties into MQTT-aware ones.

I will do it later as I have something else in queue, so I am leaving this issue open as a reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants