Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization #175

Closed
leserg73 opened this issue Oct 22, 2021 · 9 comments
Closed

Localization #175

leserg73 opened this issue Oct 22, 2021 · 9 comments
Labels
Bug Something isn't working fixed

Comments

@leserg73
Copy link

I translated the interface lines in the settings.reg file into Russian.
The encoding of the settings.reg file is UTF-8 with BOM.
Then I replaced in the file dxgi.dll resource RCData->101 on the localized.
After launching in the properties window all lines with the label ";x "
are displayed incorrectly (see attached screenshots).

Could you please fix this.
Thank you for the very useful tool.

NotCyrillic

NotCyrillic01

@valinet
Copy link
Owner

valinet commented Oct 22, 2021

Apologies, my bad. I encoded the file in UTF-8 so it is more convenient for user editing etc, and do the conversion to UTF-16 LE which Windows uses in the code, as required to use the W versions of the APIs which only those support Unicode. Unfortunately, indeed, for choice items (;x), I inserted them directly in the menu using InsertMenuItem*A*, and with Windows not knowing about Unicode when using that, yeah, bad things happen. I apologize.

Can you test this version? It should be fixed.

dxgi.zip

Also, I know this likely isn't mentioned everywhere other than the source code, but you can place the file directly besides the DLL and it will load that instead of the file in the resources of the executable. I made that so it is easier when testing. Also, you can test the interface by placing dxgi.dll and settings.reg in any folder and running rundll32 dxgi.dll,ZZGUI in that folder.

Thanks.

@valinet valinet added Bug Something isn't working fixed labels Oct 22, 2021
@JRC18
Copy link

JRC18 commented Oct 22, 2021

Working for me. Thank you sir.

@leserg73
Copy link
Author

Thank you very much. Now the strings are displayed correctly.

NotCyrillic03

But I still had to do a replacement in the file resources, because running "rundll32 dxgi.dll,ZZGUI" on the command line does not work for me. I get an error message: "No entry point: ZZGUI".

NotCyrillic02

If the settings.reg file is next to dxgi.dll (in the Windows folder), it is not loaded automatically (when restart the system). Maybe I misunderstood something (Google translator). Sorry.

But it doesn't matter to me. The main thing works interface in Russian.
Thank you for your great work.

@valinet
Copy link
Owner

valinet commented Oct 22, 2021 via email

@JRC18
Copy link

JRC18 commented Oct 22, 2021

I have a shortcut on my desktop that uses: rundll32 C:\Windows\explorer.exe,ZZGUI
And continues to work without any message. I am english, just saying incase it is a translation thing.

@leserg73
Copy link
Author

Yes, with full path (rundll32 c:\Windows\dxgi.dll,ZZGUI) work fine!
Thanks.

For Russian users (translation into Russian of 22.10.2021):
settings_rus.zip

@Galixte
Copy link

Galixte commented Nov 9, 2021

Hi @valinet,

Thanks for your tool, it’s very useful and much appreciated!

Please find the FRENCH translation of ExplorerPatcher settings.reg file for:

Other localisations are available here: #363.

Regards.

@Hunter23071985
Copy link

Please add the translation of leserg73 to the About section of Properties window.

@pyrates999
Copy link

Please add the translation of leserg73 to the About section of Properties window.

Please open a new discussion as this has been closed for over 2 years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

6 participants