Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Docker image domain resolution #18

Closed
ruksi opened this issue Jun 8, 2022 · 1 comment
Closed

Improve Docker image domain resolution #18

ruksi opened this issue Jun 8, 2022 · 1 comment
Assignees
Labels
type:bug Something isn't working

Comments

@ruksi
Copy link
Member

ruksi commented Jun 8, 2022

The logic should be something on the lines of:

TL;DR: The hostname must contain a . DNS separator, a : port separator, or the value localhost before the first /. Otherwise the code assumes you want the default registry, Docker Hub. [docker.io]

Ref: https://stackoverflow.com/a/37867949

As an extra detail, the laituri package should expose the Docker image name parsing as a function in such a way that at least the domain could be resolved when used (other parts and the exact structure are left to the implementer.)

Might also consider the term domain as it can also contain the :port, registry_address maybe?

@ruksi ruksi added the type:bug Something isn't working label Jun 8, 2022
@magdapoppins magdapoppins self-assigned this Jun 8, 2022
@akx
Copy link
Member

akx commented Jun 14, 2022

Fixed by #19, released in v0.3.0.

@akx akx closed this as completed Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants