Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feta(build): update to Angular 8. Use Angular CLI instead of ngm for building. Ensure compatibility with Ivy on application side. #1107

Merged
merged 10 commits into from
Oct 23, 2019
Merged

feta(build): update to Angular 8. Use Angular CLI instead of ngm for building. Ensure compatibility with Ivy on application side. #1107

merged 10 commits into from
Oct 23, 2019

Commits on Aug 27, 2019

  1. Update to @angular/core@6.0.0, @angular/cli@6.2.8, rxjs@6.0.0 

    Aux changes:
- Added package-lock.json to lock dependency versions
- Removed unused @angular/http from dependencies
    @earshinov
    earshinov committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    01c2d17 View commit details
    Browse the repository at this point in the history

  2. Use ng update to convert .angular-cli.json into angular.json

    @earshinov
    earshinov committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    77f2466 View commit details
    Browse the repository at this point in the history

  3. Repair npm run test

    @earshinov
    earshinov committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    268534b View commit details
    Browse the repository at this point in the history

  4. Run ng update to update to latest Angular 8.3.0

    @earshinov
    earshinov committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    7b4f871 View commit details
    Browse the repository at this point in the history

  5. Remove unused dependency ng2-page-scroll

    @earshinov
    earshinov committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    9fae840 View commit details
    Browse the repository at this point in the history

  6. Update tslint and tslint-config-valorsoft

    @earshinov
    earshinov committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    49a3334 View commit details
    Browse the repository at this point in the history

  7. Remove unused i18n and e2e stuff from angular.json

    @earshinov
    earshinov committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    6cb3f87 View commit details
    Browse the repository at this point in the history

  8. Use Angular CLI instead of ngm for building 

    Some commands:

npm run build      - to build the library.  Output is in dist/ng2-file-upload/.
npm run test       - to run tests.  Coverage report is in coverage/ as before.
npm run demo.serve - to build demo application and serve it through browsersync
npm run start      - to run demo application using `ng serve`.  Requires the library to be built and linked first.
    @earshinov
    earshinov committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    7a34226 View commit details
    Browse the repository at this point in the history

  9. Provide angularCompilerOptions to ensure compatibility with Ivy (on t… 

    …he application side)

Without this configuration, the following error occurs:

```
error TS-996002: Appears in the NgModule.imports of ...Module, but could not be resolved to an NgModule class
```

Configuruation taken from https://github.com/froala/angular-froala-wysiwyg/pull/329/files#diff-bb630a56aac9aa4924037d7db039769d
    @earshinov
    earshinov committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    2888f4c View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2019

  1. fix(ci): fix xvfb service issue

    @Domainv
    Domainv committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    33ac156 View commit details
    Browse the repository at this point in the history