Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timepicker: Placeholders are not editable #3544

Closed
TomONeill opened this issue Jan 25, 2018 · 4 comments · Fixed by #5429
Closed

Timepicker: Placeholders are not editable #3544

TomONeill opened this issue Jan 25, 2018 · 4 comments · Fixed by #5429
Labels
comp(timepicker) effort1: easy (hours) enhancement

Comments

@TomONeill
Copy link

TomONeill commented Jan 25, 2018 •
edited

The Timepicker has placeholders in the inputs (HH, MM, SS) that are hardcoded in the template. HH, MM and SS are not valid in the language I'm developing for, so I need to be able to turn those off.

Could you look into the possibility of changing the placeholders manually or perhaps turn them off entirely?

Thank you in advance.

https://github.com/valor-software/ngx-bootstrap/blob/development/src/timepicker/timepicker.component.html
TomONeill pushed a commit to TomONeill/ngx-bootstrap that referenced this issue Feb 15, 2018
Timepicker: Added showPlaceholders boolean. Ref valor-software#3544
ca21b40
@TomONeill TomONeill mentioned this issue Feb 15, 2018
Closed
fhuschle pushed a commit to fhuschle/ngx-bootstrap that referenced this issue Oct 5, 2019
@nlbhuf
feat(timepicker): add custom placeholder (valor-software#3544)
d992b04
fhuschle pushed a commit to fhuschle/ngx-bootstrap that referenced this issue Oct 5, 2019
@nlbhuf
feat(timepicker): add custom placeholder (valor-software#3544)
e515d8b
fhuschle pushed a commit to fhuschle/ngx-bootstrap that referenced this issue Oct 5, 2019
@nlbhuf
feat(timepicker): add custom placeholder (valor-software#3544)
5c578c5
@fhuschle fhuschle mentioned this issue Oct 6, 2019
Merged
5 tasks
@urstrulykkr
Copy link

Hi @daniloff200
I would like to work on this issue.

@daniloff200
Copy link
Contributor

@urstrulykkr looks like, we have a PR from @fhuschle already.

@urstrulykkr
Copy link

urstrulykkr commented Oct 17, 2019 •
edited

@daniloff200 , Can you please assign me to any beginner level hacktoberfest issue?
Thanks in advance :)

@daniloff200
Copy link
Contributor

daniloff200 commented Oct 17, 2019 •
edited

@urstrulykkr you can try to pick https://github.com/valor-software/ngx-bootstrap/issues/5401 , I added a description, what has to be done, so, I think it's good to go!
Feel free to ask any questions in this issue, if you have any

Domainv pushed a commit that referenced this issue Oct 24, 2019
@fhuschle @Domainv
feat(timepicker): add custom placeholder (#3544) (#5429)
05a215c
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this issue Jan 20, 2020
@fhuschle @IraErshova
feat(timepicker): add custom placeholder (valor-software#3544) (valor…
3bdba21 
…-software#5429)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp(timepicker) effort1: easy (hours) enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(timepicker): add custom placeholder (#3544) fhuschle/ngx-bootstrap
5 participants
@TomONeill @daniloff200 @Domainv @IlyaSurmay @urstrulykkr