Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(timepicker): add custom placeholder (#3544) #5429

Merged

Conversation

fhuschle
Copy link
Contributor

@fhuschle fhuschle commented Oct 5, 2019

PR Checklist

closes #3544

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Oct 5, 2019

Codecov Report

Merging #5429 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5429   +/-   ##
============================================
  Coverage        52.52%   52.52%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                52       52           
  Misses              37       37           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1035c0b...4a3d6f4. Read the comment docs.

Copy link
Contributor

@daniloff200 daniloff200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that locally, LGTM

@Domainv Domainv added this to the 5.3.1 milestone Oct 24, 2019
@Domainv Domainv merged commit 05a215c into valor-software:development Oct 24, 2019
@daniloff200
Copy link
Contributor

hey @fhuschle !
Thanks again for the PR!
Could you please fill out this form so we can send some swag to you? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timepicker: Placeholders are not editable
4 participants