Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daterangepicker: Max date range feature #5562

Closed
JelleVisser opened this issue Dec 3, 2019 · 4 comments · Fixed by #5684
Closed

Daterangepicker: Max date range feature #5562

JelleVisser opened this issue Dec 3, 2019 · 4 comments · Fixed by #5684
Assignees
@arvindm95
Labels
comp(datepicker) enhancement

Comments

@JelleVisser
Copy link

Is your feature request related to a problem? Please describe.
We would like to be able to enforce that a selected date range is not larger then for example "6 months".

Describe the solution you'd like
Setting this value would allow you to select any date between the existing minDate/maxDate, after selecting the first date the dates that don't fall within the maximumDateRange would be disabled

Describe alternatives you've considered
I tried to modify the minDate/maxDate after selecting the first date of the dateRange. But I didn't see any callback or method that responds to selecting the first date
@daniloff200
Copy link
Contributor

There's look like #5636, but, we don't have such functionality yet :(

@arvindm95
Copy link
Contributor

@daniloff200 If this feature is approved, Can I work on this?

@daniloff200
Copy link
Contributor

@arvindm95 yeah, that will be very cool!!!
Feel free to pick it, I very appreciate it!

arvindm95 pushed a commit to arvindm95/ngx-bootstrap that referenced this issue Feb 20, 2020
@Arvind-Muthuraman-Coda
feat(datepicker): add max date range feature to daterangepicker (valo…
6d55909 
…r-software#5562)
arvindm95 pushed a commit to arvindm95/ngx-bootstrap that referenced this issue Feb 21, 2020
@Arvind-Muthuraman-Coda
docs(datepicker): add demo and documentation to daterangepicker - max…
cb29949 
… date range feature (valor-software#5562)
arvindm95 pushed a commit to arvindm95/ngx-bootstrap that referenced this issue Feb 21, 2020
@Arvind-Muthuraman-Coda
feat(datepicker): reset maxdate on inline daterangepicker once user s…
67fe30d 
…elects the end date (valor-software#5562)
arvindm95 pushed a commit to arvindm95/ngx-bootstrap that referenced this issue Feb 21, 2020
@Arvind-Muthuraman-Coda
test(datepicker): add tests to max date range feature (valor-software…
7aeda5e 
…#5562)
arvindm95 pushed a commit to arvindm95/ngx-bootstrap that referenced this issue Feb 21, 2020
@Arvind-Muthuraman-Coda
fix(datepicker): handle max date range case when user selects second …
b3da76e 
…date < first date, max date range should re-render (valor-software#5562)
@arvindm95 arvindm95 mentioned this issue Feb 21, 2020
Merged
5 tasks
arvindm95 pushed a commit to arvindm95/ngx-bootstrap that referenced this issue Feb 21, 2020
@Arvind-Muthuraman-Coda
refactor(datepicker): add return type to method (valor-software#5562)
c45491a
@pusherman
Copy link

@arvindm95 - the opposite of this would be super helpful for us. We need a way to enforce a minimum date range (eg user must pick at least a week). Is that something that could be easily worked in while you are on it?

arvindm95 pushed a commit to arvindm95/ngx-bootstrap that referenced this issue Jul 1, 2020
@Arvind-Muthuraman-Coda
feat(datepicker): add max date range feature to daterangepicker (valo…
5410fe4 
…r-software#5562)
arvindm95 pushed a commit to arvindm95/ngx-bootstrap that referenced this issue Jul 1, 2020
@Arvind-Muthuraman-Coda
docs(datepicker): add demo and documentation to daterangepicker - max…
a80c4c0 
… date range feature (valor-software#5562)
arvindm95 pushed a commit to arvindm95/ngx-bootstrap that referenced this issue Jul 1, 2020
@Arvind-Muthuraman-Coda
feat(datepicker): reset maxdate on inline daterangepicker once user s…
f915cb3 
…elects the end date (valor-software#5562)
arvindm95 pushed a commit to arvindm95/ngx-bootstrap that referenced this issue Jul 1, 2020
@Arvind-Muthuraman-Coda
test(datepicker): add tests to max date range feature (valor-software…
20f840a 
…#5562)
arvindm95 pushed a commit to arvindm95/ngx-bootstrap that referenced this issue Jul 1, 2020
@Arvind-Muthuraman-Coda
fix(datepicker): handle max date range case when user selects second …
c03e044 
…date < first date, max date range should re-render (valor-software#5562)
arvindm95 pushed a commit to arvindm95/ngx-bootstrap that referenced this issue Jul 1, 2020
@Arvind-Muthuraman-Coda
refactor(datepicker): add return type to method (valor-software#5562)
01d9cfe
daniloff200 added a commit that referenced this issue Jul 14, 2020
@arvindm95 @Arvind-Muthuraman-Coda @daniloff200
feat(datepicker): max date range for daterangepicker (#5562) (#5684)
539dc28 
* feat(datepicker): add max date range feature to daterangepicker (#5562)

* docs(datepicker): add demo and documentation to daterangepicker - max date range feature (#5562)

* feat(datepicker): reset maxdate on inline daterangepicker once user selects the end date (#5562)

* test(datepicker): add tests to max date range feature (#5562)

* fix(datepicker): handle max date range case when user selects second date < first date, max date range should re-render (#5562)

* refactor(datepicker): add return type to method (#5562)

* feat(datepicker): add max date range feature to daterangepicker (#5562)

* docs(datepicker): add demo and documentation to daterangepicker - max date range feature (#5562)

* feat(datepicker): reset maxdate on inline daterangepicker once user selects the end date (#5562)

* test(datepicker): add tests to max date range feature (#5562)

* fix(datepicker): handle max date range case when user selects second date < first date, max date range should re-render (#5562)

* refactor(datepicker): add return type to method (#5562)

Co-authored-by: Arvind Muthuraman <arvind.muthuraman@coda.global>
Co-authored-by: Dmitriy Danilov <daniloff200@gmail.com>
@Shyam268 Shyam268 mentioned this issue Aug 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arvindm95 arvindm95

Labels
comp(datepicker) enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(datepicker): max date range for daterangepicker (#5562) arvindm95/ngx-bootstrap
4 participants
@pusherman @JelleVisser @arvindm95 @daniloff200