Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added minuteRoundBeforeStep option to timepicker #1814

Closed
wants to merge 2 commits into from
Closed

Added minuteRoundBeforeStep option to timepicker #1814

wants to merge 2 commits into from

Conversation

anandchakru
Copy link

if minuteRoundBeforeStep is true (default true), On first step, round current time to nearest minuteStep.

Example: if current time is 05:23 and minuteStep is 5 increment will be in this order 05:25, 05:30, 05:35

@codecov-io
Copy link

Codecov Report

Merging #1814 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #1814   +/-   ##
============================================
  Coverage        85.95%   85.95%           
============================================
  Files               78       78           
  Lines             2101     2101           
  Branches           273      273           
============================================
  Hits              1806     1806           
  Misses             202      202           
  Partials            93       93

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31cba41...1b7ca0e. Read the comment docs.

@valorkin
Copy link
Member

@anandchakru hey, I have completely reworked timepicker
you can see it here #2058
hopefully you will like new version
please update PR to much new logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants