Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(timepicker): new timepicker implementation #2058

Merged
merged 14 commits into from
Jul 19, 2017
Merged

feat(timepicker): new timepicker implementation #2058

merged 14 commits into from
Jul 19, 2017

Conversation

valorkin
Copy link
Member

@valorkin valorkin commented Jun 13, 2017 •
edited

fixes #2036
fixes #1981 ( + min max demo )
fixes #1973
close #1957 ( + seconds demo )
fixes #1935
fixes #1672
feat #1007 added keyboard and mousewheel support
fixes #962
fixes #793
fixes #173
fixes #1271 added custom validation demo
fixes #1539 bs4
fixes #1253 if input is invalid

todo

@codecov
Copy link

codecov bot commented Jun 13, 2017 •
edited

Codecov Report

Merging #2058 into development will increase coverage by 1.5%.
The diff coverage is 94.55%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #2058     +/-   ##
==============================================
+ Coverage        87.16%   88.66%   +1.5%     
==============================================
  Files               85       95     +10     
  Lines             2267     2921    +654     
  Branches           293      414    +121     
==============================================
+ Hits              1976     2590    +614     
- Misses             188      219     +31     
- Partials           103      112      +9
Impacted Files Coverage Δ
src/timepicker/reducer/timepicker.actions.ts 100% <100%> (ø)
src/timepicker/timepicker.module.ts 100% <100%> (ø)
src/timepicker/reducer/timepicker.store.ts 100% <100%> (ø)
src/mini-ngrx/store.class.ts 100% <100%> (ø)
src/timepicker/timepicker.config.ts 100% <100%> (ø)
src/mini-ngrx/state.class.ts 84.61% <84.61%> (ø)
src/timepicker/reducer/timepicker.reducer.ts 90% <90%> (ø)
src/timepicker/timepicker.utils.ts 92.2% <92.2%> (ø)
src/timepicker/timepicker.component.ts 95.28% <94.89%> (ø)
src/timepicker/timepicker-controls.util.ts 95.31% <95.31%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46419e3...4d74126. Read the comment docs.

@artemvfrolov artemvfrolov mentioned this pull request Jun 15, 2017
Closed
@valorkin valorkin mentioned this pull request Jun 19, 2017
Closed
IlyaSurmay and others added 4 commits July 7, 2017 16:22
@IlyaSurmay
fix(tests): fix tests & aot errors
696d120
@valorkin
fix(timepicker): min max restrictions
325a7e1
@valorkin
fix(timepicker): min max checks
21e48e5
@IlyaSurmay @valorkin
feat(timepicker): add inputs validation (#2187)
7e80486 
* feat(timepicker): add inputs validation

* fix(timepicker): add isPM support

* feat(timepicker): add isValid output
@SergeyKuryatnick
Copy link
Contributor

npm start failed with:
87f26b299c

@SergeyKuryatnick
Copy link
Contributor

#1253 - checked
#1981 - checked
#2036 - checked
#1957 - checked
#1007 - checked
#793 - checked
#1271 - checked
#1935 - dont know what that issue mean
#1672 - need add to demo
#1973 and #962 and #173 - onChaned not work

#1814 - need to check

@SergeyKuryatnick
Copy link
Contributor

Changes works normally - checked

This was referenced Jul 18, 2017
Closed
Closed
@valorkin valorkin merged commit 4a37406 into development Jul 19, 2017
@valorkin valorkin deleted the feat-timepicker branch July 19, 2017 12:46
@IlyaSurmay IlyaSurmay mentioned this pull request Jul 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comp(timepicker) ready for merge
Projects
None yet
Milestone
No milestone
4 participants
@valorkin @SergeyKuryatnick @IlyaSurmay @artemvfrolov