Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): express to nestjs in ssr #5152

Merged
merged 3 commits into from
Apr 7, 2019
Merged

feat(build): express to nestjs in ssr #5152

merged 3 commits into from
Apr 7, 2019

Conversation

Domainv
Copy link
Contributor

@Domainv Domainv commented Apr 5, 2019

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost assigned Domainv Apr 5, 2019
@ghost ghost added the needs review label Apr 5, 2019
@codecov
Copy link

codecov bot commented Apr 7, 2019

Codecov Report

Merging #5152 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5152   +/-   ##
============================================
  Coverage        51.51%   51.51%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                51       51           
  Misses              38       38           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac64b9...29e86a9. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 7, 2019

Codecov Report

Merging #5152 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5152   +/-   ##
============================================
  Coverage        51.51%   51.51%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                51       51           
  Misses              38       38           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac64b9...65ba11d. Read the comment docs.

@Domainv Domainv force-pushed the nest-ssr branch 2 times, most recently from d642cfa to 146b7c5 Compare April 7, 2019 18:33
@Domainv Domainv merged commit 2b7a2fd into development Apr 7, 2019
@ghost ghost removed the needs review label Apr 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the nest-ssr branch April 7, 2019 18:44
@Domainv Domainv restored the nest-ssr branch April 7, 2019 18:44
@Domainv Domainv deleted the nest-ssr branch May 24, 2019 08:11
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
* feat(build): change express to nestjs in ssr app
* fix(demo): location is not defined
IraErshova pushed a commit to IraErshova/ngx-bootstrap that referenced this pull request Jan 20, 2020
* feat(build): change express to nestjs in ssr app
* fix(demo): location is not defined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant