Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: FR-CA integration #6598

Merged

Conversation

alihasan00
Copy link
Contributor

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@alihasan00 alihasan00 changed the title Feature/fr ca integration [Feature]: FR-CA integration Jul 12, 2023
@valorkin valorkin self-assigned this Jul 14, 2023
@valorkin
Copy link
Member

could you please migrate tests?

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #6598 (a52b614) into development (2df6e6a) will decrease coverage by 0.10%.
The diff coverage is 12.50%.

❗ Current head a52b614 differs from pull request most recent head 24df17b. Consider uploading reports for the commit 24df17b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6598      +/-   ##
===============================================
- Coverage        76.83%   76.74%   -0.10%     
===============================================
  Files              315      316       +1     
  Lines            10682    10698      +16     
  Branches          2786     2798      +12     
===============================================
+ Hits              8208     8210       +2     
- Misses            2473     2487      +14     
  Partials             1        1              
Files Changed Coverage Δ
src/chronos/i18n/fr-ca.ts 6.66% <6.66%> (ø)
src/chronos/public_api.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2df6e6a...24df17b. Read the comment docs.

@lexasq lexasq merged commit d210ca6 into valor-software:development Jul 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants