Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wallet] Using non-global namespaces for error messages is broken #778

Closed
tarikbellamine opened this issue May 21, 2020 · 0 comments
Closed

[Wallet] Using non-global namespaces for error messages is broken #778

tarikbellamine opened this issue May 21, 2020 · 0 comments
Assignees
@jeanregisser
Labels
needs priority An issue that needs prioritization stale An issue that might be irrelevant wallet

Comments

@tarikbellamine
Copy link
Contributor

Expected Behavior

When using non-global namespaces for error messages, the alert messaging works as expected.

Current Behavior

When attempting to use any namespace that is not global, the error message does not display correctly. This is likely happening because the showError function in mobile/src/alert/actions.ts forces use of the global namespace.

As an example, SMS_ERROR in mobile/src/app/ErrorMessages.ts renders as "walletFlow5:SMSError" instead of "Error sending SMS".
@MuckT MuckT transferred this issue from celo-org/celo-monorepo Jul 6, 2021
@MuckT MuckT added the wallet label Jul 7, 2021
@silasbw silasbw added the stale An issue that might be irrelevant label Oct 30, 2021
@tarikbellamine tarikbellamine added needs priority An issue that needs prioritization and removed stale An issue that might be irrelevant labels Nov 2, 2021
@silasbw silasbw added the stale An issue that might be irrelevant label Dec 21, 2022
@silasbw silasbw closed this as completed Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanregisser jeanregisser

Labels
needs priority An issue that needs prioritization stale An issue that might be irrelevant wallet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jeanregisser @silasbw @MuckT @tarikbellamine