-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add jumpstart button to select recipients screen #4965
Conversation
1 build increased size
Celo (test) 1.79.0 (144)
|
Item | Install Size Change |
---|---|
📝 splashBackground@3x.jpg | ⬆️ 600.2 kB |
📝 background@3x.jpg | ⬆️ 368.6 kB |
📝 boost-rewards@3x.png | ⬆️ 188.4 kB |
📝 background@2x.jpg | ⬆️ 176.1 kB |
📝 boost-rewards@2x.png | ⬆️ 90.1 kB |
🛸 Powered by Emerge Tools
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4965 +/- ##
==========================================
+ Coverage 85.35% 85.37% +0.01%
==========================================
Files 714 716 +2
Lines 29184 29229 +45
Branches 5082 5086 +4
==========================================
+ Hits 24911 24953 +42
- Misses 4034 4037 +3
Partials 239 239
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
243e6c6
to
f214bdb
Compare
1 build increased size
Celo (test) 1.79.0 (144)
|
Item | Install Size Change |
---|---|
📝 splashBackground@3x.jpg | ⬆️ 600.2 kB |
📝 background@3x.jpg | ⬆️ 368.6 kB |
📝 boost-rewards@3x.png | ⬆️ 188.4 kB |
📝 background@2x.jpg | ⬆️ 176.1 kB |
📝 boost-rewards@2x.png | ⬆️ 90.1 kB |
🛸 Powered by Emerge Tools
1 build increased size
Celo (test) 1.79.0 (144)
|
Item | Install Size Change |
---|---|
📝 splashBackground@3x.jpg | ⬆️ 600.2 kB |
📝 background@3x.jpg | ⬆️ 368.6 kB |
📝 boost-rewards@3x.png | ⬆️ 188.4 kB |
📝 background@2x.jpg | ⬆️ 176.1 kB |
📝 boost-rewards@2x.png | ⬆️ 90.1 kB |
🛸 Powered by Emerge Tools
return | ||
} | ||
|
||
const recipient = route.params.recipient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the reason behind moving the recepeint
declaration here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, type guard 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes 🙈 typescript doesn't let me destructure this from the route.params when it may not exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪄
1 build increased size
Celo (test) 1.79.0 (144)
|
Item | Install Size Change |
---|---|
📝 splashBackground@3x.jpg | ⬆️ 600.2 kB |
📝 background@3x.jpg | ⬆️ 368.6 kB |
📝 boost-rewards@3x.png | ⬆️ 188.4 kB |
📝 background@2x.jpg | ⬆️ 176.1 kB |
📝 boost-rewards@2x.png | ⬆️ 90.1 kB |
🛸 Powered by Emerge Tools
### Description This PR adds the remote config and button for the start of the escrow jumpstart flow. I think that the most straightforward way to implement the escrow flow is to use the existing send flow rather than separate the flows. I've made a POC that is working e2e in valora-inc#4964, in case it helps to understand this decision. ### Test plan ![Simulator Screenshot - iPhone 14 Pro - 2024-02-23 at 12 22 01](https://github.com/valora-inc/wallet/assets/20150449/8b524157-4c52-481b-af68-b7a3d47885ca) ### Related issues - Related to RET-993 ### Backwards compatibility Y ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Description
This PR adds the remote config and button for the start of the escrow jumpstart flow. I think that the most straightforward way to implement the escrow flow is to use the existing send flow rather than separate the flows. I've made a POC that is working e2e in #4964, in case it helps to understand this decision.
Test plan
Related issues
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: