chore: all of the plumbing for escrow send #4964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 23, 2024
kathaypacific
added a commit
that referenced
this pull request
Feb 23, 2024
### Description As the title. Using a .ts file allows static type checking with typescript when using the abi with viem. This will be useful for upcoming PRs relating to escrow (see #4964) ### Test plan n/a ### Related issues - Related to RET-993 ### Backwards compatibility Y ### Network scalability Y
kathaypacific
added a commit
that referenced
this pull request
Feb 23, 2024
### Description This PR adds the remote config and button for the start of the escrow jumpstart flow. I think that the most straightforward way to implement the escrow flow is to use the existing send flow rather than separate the flows. I've made a POC that is working e2e in #4964, in case it helps to understand this decision. ### Test plan  ### Related issues - Related to RET-993 ### Backwards compatibility Y ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
### Description As the title. Using a .ts file allows static type checking with typescript when using the abi with viem. This will be useful for upcoming PRs relating to escrow (see valora-inc#4964) ### Test plan n/a ### Related issues - Related to RET-993 ### Backwards compatibility Y ### Network scalability Y
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
### Description This PR adds the remote config and button for the start of the escrow jumpstart flow. I think that the most straightforward way to implement the escrow flow is to use the existing send flow rather than separate the flows. I've made a POC that is working e2e in valora-inc#4964, in case it helps to understand this decision. ### Test plan  ### Related issues - Related to RET-993 ### Backwards compatibility Y ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test plan
Related issues
Backwards compatibility
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: