Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performative check #98

Open
Karrenbelt opened this issue Sep 1, 2022 · 2 comments
Open

Performative check #98

Karrenbelt opened this issue Sep 1, 2022 · 2 comments

Comments

@Karrenbelt
Copy link
Contributor

Ledger and contract api calls can result in an incorrect (e.g. error) performative. We should return specific failure response, and deal with this event separately. We might also raise a custom IncorrectPerformativeError which can be intercepted at the level of the round, where all errors may transition to PathSelectionRound.

@Karrenbelt
Copy link
Contributor Author

Karrenbelt commented Sep 3, 2022

addressed in #106 and #107. In case of an incorrect performative (e.g. error response from contract call) the behaviours return None and the agents do not deliver a payload. This is probably not ideal because once reset hits it will transition to the same round. Instead an ErrorPayload may be considered, an on a majority vote a transition back to the initial PathSelection. Eventually, repeated and continuous cycling back to PathSelectionRound with ErrorPayload the application may transition into a degenerate round (Event.UNKNOWN_HEALTH_ISSUE)

@Karrenbelt
Copy link
Contributor Author

TODO:

Address inconsistencies in error handling: #106 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant