Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX of password: validate if password is correct immediately after asking. #120

Open
jmoreira-valory opened this issue Nov 21, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@jmoreira-valory
Copy link
Collaborator

jmoreira-valory commented Nov 21, 2023

Currently, the script works as follows:

  1. Asks for password
  2. Downloads trader repository
  3. Validates password after downloading trader repository.

The user might notice that the script proceeds to step 2 even after introducing a wrong password (but it will fail validating it later...).

This may give the impression to the user that the script is proceeding with a wrong password...

A possible improvement is to validate immediately after the user enters the password. This would require refactor when the trader repository is downloaded.

@dagacha
Copy link
Collaborator

dagacha commented Nov 21, 2023

Another UX improvement would help Mac users to avoid confusion between two passwords: service-level password and sudo password.

Namely, the script asks for a first password (service-level)

Enter your password

Your key files are protected with a password.
Please, enter your password: 

later in the execution it may ask for a password again (sudo password)

Generated Deployment!


Type:                 docker-compose
Agents:               1
Build Length          10799



Password:

@jmoreira-valory jmoreira-valory added the enhancement New feature or request label Nov 23, 2023
@jmoreira-valory jmoreira-valory changed the title [password] Improve UX of password: validate if password is correct immediately after asking. Improve UX of password: validate if password is correct immediately after asking. Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants