Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response headers are converted to atoms #99

Closed
schnittchen opened this issue Oct 1, 2016 · 2 comments
Closed

Response headers are converted to atoms #99

schnittchen opened this issue Oct 1, 2016 · 2 comments

Comments

@schnittchen
Copy link

Here: https://github.com/myfreeweb/httpotion/blob/master/lib/httpotion.ex#L73

Response headers are out of control of the application author and should be treated like user input. Converting string user input to atoms will eventually crash the machine. See also https://erlangcentral.org/wiki/index.php/Atom_Table

@valpackett
Copy link
Owner

Thanks! Released 3.0.2 with the fix.

@schnittchen
Copy link
Author

That was swift! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants