Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncbase: Clarify if we do support non-VOM data #1100

Open
aghassemi opened this issue Jan 29, 2016 · 0 comments
Open

Syncbase: Clarify if we do support non-VOM data #1100

aghassemi opened this issue Jan 29, 2016 · 0 comments
Assignees
Milestone

Comments

@aghassemi
Copy link
Member

Currently we have tests for reading/writing non-VOM data. Problem is queries (even if a simple SELECT k, v FROM table) fails on non-VOM data since queries return VdlValue rather than bytes.

We should clarify if we want to support non-VOM bytes as that decision can effect the design of client APIs being discussed in #1083

If we do want to support non-VOM values, then we should fix queries not to fail.
If we don't want to support non-VOM bytes, we should change the Syncbase VDL to take any instead of byte to guarantee non-VOM bytes can't make it in.

My opinion is to stick with VOM as I don't think encoding bytes as VOM bytes is expensive.

@kenashcraft @asadovsky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant