Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Joining a presentation goes to slidelist page instead of slideshow #22

Closed
aghassemi opened this issue Dec 4, 2015 · 2 comments
Closed

Joining a presentation goes to slidelist page instead of slideshow #22

aghassemi opened this issue Dec 4, 2015 · 2 comments
Labels
Dart

Comments

@aghassemi
Copy link
Contributor

Regression likely due to Flutter's change of behaviour with Navigators. We do a push of listslide page before pushing the slideshow so back button goes back to list, this is probably the cause of this issue.

if we can't find a easy solution for this, we don't need to have the back button go to slidelist page so we can just push the slideshow.
@aghassemi aghassemi added the Dart label Dec 4, 2015
@mishadynin
Copy link
Contributor

Accepted, can reproduce, looking into it.

vanadium-bot pushed a commit that referenced this issue Dec 5, 2015
@mishadynin
Fix Flutter-related bugs in syncslides:
839cee7 
Joining a presentation goes to slidelist page instead of slideshow
#22

Tapping back button on main decks grid page crashes the app
#23

Update Flutter version.  Update the app to use the new Drawer API.

Change-Id: Id98233ca52d336e160696358c8d30263b6b533cb
@mishadynin
Copy link
Contributor

Fixed in 839cee7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Dart
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aghassemi @mishadynin