arbotix_python for ROS Noetic #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeferguson
requested changes
Dec 25, 2020
arbotix_python/CHANGELOG.rst
Outdated
| @@ -2,6 +2,13 @@ | |||
| Changelog for package arbotix_python | |||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |||
|
|
|||
| 0.11.0 (2020-12-25) | |||
There was a problem hiding this comment.
please revert the changes to the CHANGELOG - this is automatically generated when I do the release.
arbotix_python/package.xml
Outdated
| <name>arbotix_python</name> | ||
| <version>0.10.0</version> | ||
| <version>0.11.0</version> |
There was a problem hiding this comment.
please revert this one line
Ouch - reverted the autostuff. I would leave the shebangs as is until somebody posts an issue :D. It worked with python 2, now works with python 3. If you prefer to explicitly name the version, give me a sign, I'll change it. |
mikeferguson
approved these changes
Dec 25, 2020
|
Thanks for the PR and quick response to review comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Mike, yet another copy of arbotix_python working with ROS Noetic. Please give it a try. Tested arbotix_python and arbotix_terminal. I didn't touch other packages inside arbotix_ros besides the one mentioned above.