Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/certificate: subject_alternative_names doesn't need a Set func #29

Closed
wants to merge 1 commit into from

Conversation

vancluever
Copy link
Owner

@vancluever vancluever commented Feb 19, 2019

The Set func on this attribute was set to schema.HashString, which is
actually what helper/schema defaults a TypeSet with an element of
this type to anyway.

Removed it and tested on a config with a few SANs, no change.

The Set func on this attribute was set to schema.HashString, which is
actually what helper/schema defaults a TypeSet with an element of
this type to anyway.

Removed it and tested on a config with a few SANs, no change.
@vancluever
Copy link
Owner Author

Hmm, I think I'm just going to leave this one. It looks like SerializeValueForHash behaves slightly differently than a simple HashString, as it writes a semicolon at the end of the pre-hash buffer, whereas HashString just converts the value as-is without any more manipulation.

I don't know why my manual test didn't give a diff, but the honestly is not worth it enough to mess with people's states.

@vancluever vancluever closed this Feb 19, 2019
@vancluever vancluever deleted the b-set-funcs branch March 15, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant