Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Q] Why does Vanilo use Concord? #37

Closed
jhm-ciberman opened this issue Mar 2, 2019 · 1 comment
Closed

[Q] Why does Vanilo use Concord? #37

jhm-ciberman opened this issue Mar 2, 2019 · 1 comment

Comments

@jhm-ciberman
Copy link

I started to use this package but I don't find any explanation on why it's built on top of concord ugly module system.

The default Laravel extensions system is organized enough, and I think using concord module system only desviates Vanilo from his original objective that is to be "Simple & truly Laravel".
For example, AppShell JS & Sass resources are inside the VENDOR directory without compiling. This makes difficult to unit test and add CI because you need not only to compile your custom assets but also the vendor assets on each CI pipeline. So, there is no separation of concerns for "frontend"(npm) and "backend"(composer) because the AppShell frontend resources are inside the composer vendor directory.

The laravel documentation states clearly how public assets should be handled: https://laravel.com/docs/5.8/packages#public-assets
And the concord system is not handling this well. Also, it's not offering anything that cannot be done with plain PHP.

So, I think using concord is lowering the quality of vanilo and the separation of concerns. And also adding a lot of dependencies that does not add anything useful. (Yes, I know AppShell is based on corcord, but it can be easily rewrited in plain Laravel)

So, my final question is.. why does Vanilo use Concord?

@fulopattila122
Copy link
Member

If I have to mention to most important thing Concord does, that's this: https://artkonekt.github.io/concord/#/models

When Vanilo and Concord were created, Laravel didn't have all the facilities for packages it does today.
After Vanilo release v1.0 (this month), we plan to simplify Concord in order to make it more like any other Laravel package. But that'll be a BC so it's out of the scope at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants