Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added two possibilities to expand the index name #57

Merged
merged 25 commits into from
Jul 14, 2018

Conversation

anli-xsigns
Copy link
Contributor

In a recent project I had the challenge to enable a better logging. Therefore I added two options to winston-elasticsearch:

Option 1: Enable to use a function for option property indexPrefix to use a variable name for the log.
Option 2: Introduced the indexInterfix property to be used in the log transformer to create individual logs for each log entry like prefix-interfix-suffix.

…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
@coveralls
Copy link

coveralls commented Jul 4, 2018

Coverage Status

Coverage decreased (-0.5%) to 81.69% when pulling 677addf on litti:master into 4bf2a5d on vanthome:master.

@vanthome
Copy link
Owner

vanthome commented Jul 4, 2018

lgtm but where is the documentation?

@litti
Copy link
Contributor

litti commented Jul 4, 2018

I can write it if you want to accept the pr :-) If you tend to reject it I can save my time to write the docs :-)

@vanthome
Copy link
Owner

vanthome commented Jul 4, 2018

as I said, LGTM. I just would like to see documentation and that by default (if I don't use any of the new options) the behaviour remains as it is.

@vanthome
Copy link
Owner

vanthome commented Jul 6, 2018

thx! I just accepted that other PR, would you mind rebasing yours onto master?

@litti
Copy link
Contributor

litti commented Jul 9, 2018

No problem, but don't know how to do. Just forked, made the changes, pushed them and made the pr.

@vanthome
Copy link
Owner

vanthome commented Jul 9, 2018

@litti
Copy link
Contributor

litti commented Jul 9, 2018

of course, I've googled, but it all needs a lot of time spending for this and I'm close to holiday with tons of work to do so the one thing I don't have is time ;-). So never mind, I'll delete the pr so it doesn't mix up things here.

…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
@litti
Copy link
Contributor

litti commented Jul 14, 2018

Managed to rebase today.

@vanthome vanthome merged commit 120ed10 into vanthome:master Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants