-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added two possibilities to expand the index name #57
Conversation
…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
lgtm but where is the documentation? |
I can write it if you want to accept the pr :-) If you tend to reject it I can save my time to write the docs :-) |
as I said, LGTM. I just would like to see documentation and that by default (if I don't use any of the new options) the behaviour remains as it is. |
docs and better tests
splat metadata
thx! I just accepted that other PR, would you mind rebasing yours onto master? |
…r-node6 Use object assign for node6
No problem, but don't know how to do. Just forked, made the changes, pushed them and made the pr. |
Google is your friend: https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request |
of course, I've googled, but it all needs a lot of time spending for this and I'm close to holiday with tons of work to do so the one thing I don't have is time ;-). So never mind, I'll delete the pr so it doesn't mix up things here. |
…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
…ble to log to multiple indices within one transport
Managed to rebase today. |
In a recent project I had the challenge to enable a better logging. Therefore I added two options to winston-elasticsearch:
Option 1: Enable to use a function for option property indexPrefix to use a variable name for the log.
Option 2: Introduced the indexInterfix property to be used in the log transformer to create individual logs for each log entry like prefix-interfix-suffix.