-MF"apps/bcl_apps.d" -MT"apps/bcl_apps.d" fails to distribute

[GoogleCodeExporter]

Using version:
2.18.3
3.0rc2

Platform:
redhat linux x86_64
building from source using gcc4.3.0

trying to:
build own project using eclipse 3.4 (ganymede) with cdt

what went wrong:
it fails to distribute the job, since eclipse cdt does not add a space
between options "-MF", "-MT" but the comments in arg.c states that those
options are ok for distributing - but it does not check if flag and
argument are indeed separated by a space

Example:
distcc g++ -I../include -I../example
-I../extern/noarch/mysql/5.0.51a/include
-I../extern/noarch/mysqlpp/3.0.0/include -O0 -g3 -Wall -c
-fmessage-length=0 -Wno-deprecated -MMD -MP -MF"apps/apps.d"
-MT"apps/apps.d" -o"apps/apps.o" "../apps/apps.cpp"

all clients are connected by ssh and have varieing numbers of processors,
all with the lzo option

Solution:
We fixed that by replacing the strcmp function with a strncmp function,
that only compares the first n characters.
Our project compiles just fine with that - but we might have overlooked
something.

Patch: in the attachment

Original issue reported on code.google.com by nilswoet...@gmail.com on 12 Jul 2008 at 7:05

Attachments:

• MD_MMD_MG_MP_MF_MT_MQ_distcc-3.0rc2.patch

[GoogleCodeExporter]

When submitting patches, please use at least the "-u" option, or preferably 
"-Naur",
and list the old version first on the command line, then the new version, 
rather than
the other way around.  So "diff -Naur old-directory new-directory", not "diff
new-file old-file".

Nevertheless, with some difficulty I was able to apply your patch and take a 
look at
it.  Your patch looks wrong to me - it will do the wrong thing for e.g. "gcc -MF
foo.m -c foo.c".  However, you're right that there is a bug.  I have made a 
different
patch to fix it.  Please test out this alternative patch.

Original comment by fergus.h...@gmail.com on 30 Jul 2008 at 1:50

• Changed state: Started

Attachments:

• patch2

[GoogleCodeExporter]

Original comment by fergus.h...@gmail.com on 30 Jul 2008 at 1:51

[GoogleCodeExporter]

I've submitted that patch to the mainline, so this should be fixed now, as of
revision 568.

Original comment by fergus.h...@gmail.com on 30 Jul 2008 at 2:36

• Changed state: Fixed

[GoogleCodeExporter]

The previous patch wasn't sufficient to fix the problem.
I'm working on another patch.

Original comment by fergus.h...@gmail.com on 30 Jul 2008 at 8:02

• Changed state: Started

[GoogleCodeExporter]

Fixed in revision 574.

Original comment by fergus.h...@gmail.com on 30 Jul 2008 at 10:59

[GoogleCodeExporter]

Original comment by fergus.h...@gmail.com on 30 Jul 2008 at 10:59

• Changed state: Fixed

[GoogleCodeExporter]

works without problmes in eclipse ganymede with CDT 5

Thanks

Original comment by nilswoet...@gmail.com on 8 Sep 2008 at 2:50

[GoogleCodeExporter]

Original comment by fergus.h...@gmail.com on 8 Sep 2008 at 7:33

• Changed state: Verified