Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaf 3 - templates still cached for debug builds #87

Closed
0xTim opened this issue Jan 8, 2018 · 4 comments
Closed

Leaf 3 - templates still cached for debug builds #87

0xTim opened this issue Jan 8, 2018 · 4 comments

Comments

@0xTim
Copy link
Member

0xTim commented Jan 8, 2018

In Leaf 2 templates wouldn't be cached during debug builds, and only when running in release. This doesn't appear to have been transitioned over to Leaf 3 and should be reimplemented

@tanner0101
Copy link
Member

#88 merged. This should be fixed now

@linqingmo
Copy link

@tanner0101 I think it will still cache on development.
Renderer.swift

if cache {
    leafFile = file.read(at: fullPath, chunkSize: 2048)
} else {
    leafFile = file.cachedRead(at: fullPath, chunkSize: 2048)
}

I'm not sure whether it should be

if cache {
    leafFile = file.cachedRead(at: fullPath, chunkSize: 2048)
} else {
    leafFile = file.read(at: fullPath, chunkSize: 2048)
}

@tanner0101
Copy link
Member

@linqingmo did you run swift package update? That code looks old.

@linqingmo
Copy link

@tanner0101 Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants