Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nio #23

Merged
merged 37 commits into from
Mar 21, 2018
Merged

nio #23

merged 37 commits into from
Mar 21, 2018

Conversation

tanner0101
Copy link
Member

  • use Swift NIO

@tanner0101 tanner0101 added the enhancement New feature or request label Mar 2, 2018
@tanner0101 tanner0101 added this to the 1.0.0-rc.2 milestone Mar 2, 2018
@tanner0101 tanner0101 self-assigned this Mar 2, 2018
@tanner0101 tanner0101 changed the title Nio nio Mar 2, 2018
tanner0101 and others added 21 commits March 2, 2018 21:23
@tanner0101
Move ByteBuffer utilities + QueueHandler to Core package
31a0fb8
@tanner0101
nio updates
f362d4c
@tanner0101
update to nio-based worker protocol
9f90100
added connection string parsing for PostgreSQLDatabaseConfig
7a50dfd
@tanner0101
temporary ignore channel inactive
1a0855e
@tanner0101
organization updates
6080505
@tanner0101
add isnull to psql data
49f6676
@tanner0101
fix tests
a81d233
@tanner0101
Merge pull request #27 from vapor/mysql-nio
83333e7 
nio cleanup
changed method signature, per @tanner0101
bd3d280
@tanner0101
bytebuffer updates
54ea05c
@tanner0101
publicize rawrep
efba3a4
@MrMage
Add support for persisting dates with microsecond precision.
c36db27 
Note that I have not made parsing the textual format of the timestamp type more accurate - do we need that? If so, where is that format documented?
@tanner0101
Merge pull request #29 from MrMage/fix-date-format
42fbe05 
Add support for persisting dates with microsecond precision
@MrMage
Fix a memory leak in PostgreSQLConnection
a3f4297 
`PostgreSQLTableNameCache` holds a `PostgreSQLConnection` future. Once that future is fulfilled, it strongly holds a reference to `PostgreSQLConnection`. That connection in turn holds the table name cache, so we have a reference cycle. This causes the table name cache and its connection to never get released. This is relevant when testing, if the tests are set up such that each test creates a new `Database`.
@tanner0101
Merge pull request #31 from vapor/nio-connection-leak-1
a4e81ae 
Fix a memory leak in `PostgreSQLConnection`
@tanner0101
Merge pull request #25 from pedantix/swh-add-connection-string-to-config
c2b4be0 
added connection string parsing for PostgreSQLDatabaseConfig
@tanner0101
fixes #24. combines parameterized query phases into one
265fba3
@tanner0101
also test fluentpostgresql + nightly circle ci tests
dfad288
@tanner0101
update ci psql deps
9837294
@tanner0101
add contributor bootstrap + doc
d75533d
@MrMage
Copy link
Contributor

MrMage commented Mar 14, 2018

Just so we don’t forget this: I think we need a reader/writer lock (eg. with Dispatch barriers) on PostgreSQLTableynameCache to ensure that nobody is reading from the cache while another thread is writing to it.

@tanner0101 tanner0101 merged commit 1823a1c into master Mar 21, 2018
@tanner0101 tanner0101 deleted the nio branch March 21, 2018 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tanner0101 tanner0101

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0-rc.2
Development

Successfully merging this pull request may close these issues.
3 participants
@tanner0101 @MrMage @0xTim