Improve error reporting for EncodingError and DecodingError
#2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2981 +/- ##
==========================================
- Coverage 76.77% 76.58% -0.20%
==========================================
Files 211 211
Lines 7773 7781 +8
==========================================
- Hits 5968 5959 -9
- Misses 1805 1822 +17
|
|
These changes are now available in 4.77.1 |
keniwhat
pushed a commit
to keniwhat/vapor
that referenced
this pull request
Aug 29, 2023
* main: (75 commits) Make Storage Sendable (vapor#3056) Add Sendable Conformances to undelying types (vapor#3054) Resolve issue vapor#2650 (vapor#2674) Fix for vapor#2574 Missing quote from value (vapor#2839) Allow specifying a timeout for client requests (vapor#3043) Update dependencies with known CVEs to the latest versions (vapor#3038) Create CODEOWNERS Improve error reporting for `EncodingError` and `DecodingError` (vapor#2981) Fix incorrect use of non-localhost connection in test Update README with new Sponsor (vapor#3025) Add `ContentContainer.decode(_:as:)` (vapor#3023) Fixed drain handler call order in case of asynchronous buffer handling (vapor#3009) Update README with new Sponsor (vapor#3024) Update README with new Sponsor (vapor#3020) Don't use UnsafeRawBufferPointer.withMemoryRebound(to:_:) before Swift 5.7.2 (vapor#3021) Avoid deadlocking websocket tests (vapor#3019) Update README with new Sponsor (vapor#3014) Fix `Range: bytes=0-0` header not working properly (vapor#3010) Remove use of HTTPBin (vapor#3017) Improved error logging (vapor#3016) ... # Conflicts: # Sources/Vapor/HTTP/Headers/HTTPHeaders+ContentRange.swift # Sources/Vapor/Utilities/FileIO.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
EncodingErrorandDecodingErrorboth conform toLocalizedError, error reporting uses theirlocalizedDescriptionwhich is just a generic error message.So this changes the error reporting from:
To a description much more useful (for example):