New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Storage Sendable #3056
Make Storage Sendable #3056
Conversation
Need to be careful here on how the Sendable stuff changes things like Authentication in Fluent |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3056 +/- ##
==========================================
+ Coverage 76.64% 77.05% +0.41%
==========================================
Files 211 211
Lines 7805 7871 +66
==========================================
+ Hits 5982 6065 +83
+ Misses 1823 1806 -17
|
@gwynne @FranzBusch @fabianfett this is ready for review if anyone would like to take a look |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
These changes are now available in 4.80.0 |
* main: (75 commits) Make Storage Sendable (vapor#3056) Add Sendable Conformances to undelying types (vapor#3054) Resolve issue vapor#2650 (vapor#2674) Fix for vapor#2574 Missing quote from value (vapor#2839) Allow specifying a timeout for client requests (vapor#3043) Update dependencies with known CVEs to the latest versions (vapor#3038) Create CODEOWNERS Improve error reporting for `EncodingError` and `DecodingError` (vapor#2981) Fix incorrect use of non-localhost connection in test Update README with new Sponsor (vapor#3025) Add `ContentContainer.decode(_:as:)` (vapor#3023) Fixed drain handler call order in case of asynchronous buffer handling (vapor#3009) Update README with new Sponsor (vapor#3024) Update README with new Sponsor (vapor#3020) Don't use UnsafeRawBufferPointer.withMemoryRebound(to:_:) before Swift 5.7.2 (vapor#3021) Avoid deadlocking websocket tests (vapor#3019) Update README with new Sponsor (vapor#3014) Fix `Range: bytes=0-0` header not working properly (vapor#3010) Remove use of HTTPBin (vapor#3017) Improved error logging (vapor#3016) ... # Conflicts: # Sources/Vapor/HTTP/Headers/HTTPHeaders+ContentRange.swift # Sources/Vapor/Utilities/FileIO.swift
Make Vapor's
Storage
andApplication
Sendable
. This is a key piece in allowingRequest
andResponse
to beSendable
.Note that types that are stored in
Storage
should now beSendable
. If you get any warnings, you may need to update your code for this new change.