New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ContentContainer.decode(_:as:)
#3023
Conversation
(I guess my branch name isn't accurate. Should have been something like |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3023 +/- ##
==========================================
+ Coverage 76.73% 76.77% +0.04%
==========================================
Files 211 211
Lines 7770 7773 +3
==========================================
+ Hits 5962 5968 +6
+ Misses 1808 1805 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good, would like some changes in the tests 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
ContentContainer.decode(_:as:)
ContentContainer.decode(_:as:)
Original comment:
|
These changes are now available in 4.77.0 |
* main: (75 commits) Make Storage Sendable (vapor#3056) Add Sendable Conformances to undelying types (vapor#3054) Resolve issue vapor#2650 (vapor#2674) Fix for vapor#2574 Missing quote from value (vapor#2839) Allow specifying a timeout for client requests (vapor#3043) Update dependencies with known CVEs to the latest versions (vapor#3038) Create CODEOWNERS Improve error reporting for `EncodingError` and `DecodingError` (vapor#2981) Fix incorrect use of non-localhost connection in test Update README with new Sponsor (vapor#3025) Add `ContentContainer.decode(_:as:)` (vapor#3023) Fixed drain handler call order in case of asynchronous buffer handling (vapor#3009) Update README with new Sponsor (vapor#3024) Update README with new Sponsor (vapor#3020) Don't use UnsafeRawBufferPointer.withMemoryRebound(to:_:) before Swift 5.7.2 (vapor#3021) Avoid deadlocking websocket tests (vapor#3019) Update README with new Sponsor (vapor#3014) Fix `Range: bytes=0-0` header not working properly (vapor#3010) Remove use of HTTPBin (vapor#3017) Improved error logging (vapor#3016) ... # Conflicts: # Sources/Vapor/HTTP/Headers/HTTPHeaders+ContentRange.swift # Sources/Vapor/Utilities/FileIO.swift
Adds
ContentContainer.decode(_:as:)
to complimentContentContainer.encode(_:as:)
to make it easy to override theContent-Type
if calling an API or decoding a request that returns erroneous headers for the body type.